Fix permissions issues with sandbox mounts #1211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katiewasnothere
force-pushed
the
sandbox_mounts_perm
branch
from
404e7af to
ec63fc6
Compare
ambarve
reviewed
Oct 29, 2021
| // Temporarily set the umask of this process to 0 so that we can actually | ||
| // make all dirs with os.ModePerm permissions. | ||
| savedUmask := unix.Umask(0) | ||
| if err := os.MkdirAll(sandboxSource, os.ModePerm); err != nil { |
Contributor
There was a problem hiding this comment.
This will not reset the umask if MkdirAll returns non-nil error. Can we change this to something like:
savedumask := unix.Umask(0)
defer unix.Umask(savedUmask)
err := os.MkdirAll(...)
ambarve
reviewed
Oct 29, 2021
Signed-off-by: Kathryn Baldauf <[email protected]>
katiewasnothere
force-pushed
the
sandbox_mounts_perm
branch
from
ec63fc6 to
aea3b96
Compare
Author
dcantah
approved these changes
Nov 4, 2021
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Nov 17, 2021
Related work items: microsoft#1067, microsoft#1097, microsoft#1119, microsoft#1170, microsoft#1176, microsoft#1180, microsoft#1181, microsoft#1182, microsoft#1183, microsoft#1184, microsoft#1185, microsoft#1186, microsoft#1187, microsoft#1188, microsoft#1189, microsoft#1191, microsoft#1193, microsoft#1194, microsoft#1195, microsoft#1196, microsoft#1197, microsoft#1200, microsoft#1201, microsoft#1202, microsoft#1203, microsoft#1204, microsoft#1205, microsoft#1206, microsoft#1207, microsoft#1209, microsoft#1210, microsoft#1211, microsoft#1218, microsoft#1219, microsoft#1220, microsoft#1223
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
…_perm Fix permissions issues with sandbox mounts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An issue was reported where when a user went to write files as a non-privileged user in a sandboxMount mounted with r/w in a container, they'd get a permission denied error. This was because the underlying directories in the UVM were created with 0755 permissions so only a privileged user in the container could write to a r/w sandboxMount mounted in. This PR changes that behavior by creating the underlying directories with 0777 permissions.
Signed-off-by: Kathryn Baldauf [email protected]