Revert V21H2 osversion definition #1191
Conversation
This reverts commit 7b6e3da. The reason for this is because the tag 21h2 actually refers to a couple different Windows builds now unfortunately. It's the tag for the latest Windows 10 update, for Windows 11, and Windows Server 2022. We're looking into how best to actually name these going forward if we're going to account for an event like this again. Signed-off-by: Daniel Canter <[email protected]>
katiewasnothere
left a comment
katiewasnothere
left a comment
There was a problem hiding this comment.
Jeez, that sounds like a mess. This LGTM.
|
fyi @adelina-t, sorry about this :(. We became aware of it after we'd checked it in. I'll ping you once we come up with something here |
|
would it be an idea to have multiple consts with the same value? (fwiw, older consts also could refer to multiple things (windows home, server, etc), so perhaps just a docs comment would "work" |
|
@thaJeztah The windows 10, windows 11 and windows server 21h2 all have different build numbers 😐 The idea we'd floated around so far was to have some sort of prefix to denote each. W11, W10 and WS or something similar. |
|
Ah! I misunderstood, and thought they were the same build number, but different versions, but it's the reverse. Gotcha |
|
@thaJeztah Yea, it's the worst case scenario 😔 |
Related work items: microsoft#1067, microsoft#1097, microsoft#1119, microsoft#1170, microsoft#1176, microsoft#1180, microsoft#1181, microsoft#1182, microsoft#1183, microsoft#1184, microsoft#1185, microsoft#1186, microsoft#1187, microsoft#1188, microsoft#1189, microsoft#1191, microsoft#1193, microsoft#1194, microsoft#1195, microsoft#1196, microsoft#1197, microsoft#1200, microsoft#1201, microsoft#1202, microsoft#1203, microsoft#1204, microsoft#1205, microsoft#1206, microsoft#1207, microsoft#1209, microsoft#1210, microsoft#1211, microsoft#1218, microsoft#1219, microsoft#1220, microsoft#1223
4 participants
This reverts commit 7b6e3da that added
a windows server 2022 build number. The reason
for this is because the tag 21h2 actually refers to a couple different
Windows builds now unfortunately. It's the tag for the latest Windows 10
update, for Windows 11, and Windows Server 2022. We're looking into how
best to actually name these going forward if we're going to account for an
event like this again.