Update json format for security policy #1173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmaxvl
reviewed
Sep 22, 2021
anmaxvl
reviewed
Sep 22, 2021
anmaxvl
approved these changes
Sep 24, 2021
Contributor
Author
|
@dcantah PTAL |
dcantah
reviewed
Sep 25, 2021
dcantah
reviewed
Sep 25, 2021
dcantah
reviewed
Sep 25, 2021
dcantah
reviewed
Sep 25, 2021
dcantah
reviewed
Sep 25, 2021
dcantah
reviewed
Sep 25, 2021
dcantah
reviewed
Sep 25, 2021
Contributor
|
The README should be updated with an example showing what the tool would spit out for the new format now |
Contributor
Author
|
@dcantah README has been updated. |
Contributor
Author
|
@dcantah PTAL (please take another look) |
Contributor
|
@SeanTAllen Sorry for the delay! |
dcantah
approved these changes
Sep 28, 2021
Contributor
|
Oh oop spoke too soon |
dcantah
reviewed
Sep 28, 2021
These changes come by way of a suggestion from Maksim who noted that this new format keeps the same information as the previous format, but organizes it in a way that makes it easier to maintain the creation code and can allow for the usage of a custom JSON marshaller to remove a source of possible bugs in keeping the number of elements and the field that is the length of said elements in sync, Signed-off-by: Sean T. Allen <[email protected]>
Contributor
|
Ok re-lgtm |
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Nov 17, 2021
Related work items: microsoft#1062, microsoft#1087, microsoft#1089, microsoft#1095, microsoft#1104, microsoft#1112, microsoft#1117, microsoft#1118, microsoft#1125, microsoft#1137, microsoft#1139, microsoft#1140, microsoft#1141, microsoft#1142, microsoft#1143, microsoft#1145, microsoft#1146, microsoft#1150, microsoft#1151, microsoft#1153, microsoft#1154, microsoft#1155, microsoft#1156, microsoft#1157, microsoft#1158, microsoft#1159, microsoft#1161, microsoft#1162, microsoft#1163, microsoft#1164, microsoft#1165, microsoft#1166, microsoft#1167, microsoft#1168, microsoft#1169, microsoft#1171, microsoft#1172, microsoft#1173, microsoft#1174, microsoft#1178
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
…n-format Update json format for security policy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes come by way of a suggestion from Maksim who noted that this
new format keeps the same information as the previous format, but organizes
it in a way that makes it easier to maintain the creation code and can
allow for the usage of a custom JSON marshaller to remove a source
of possible bugs in keeping the number of elements and the field that
is the length of said elements in sync,
Signed-off-by: Sean T. Allen [email protected]