Add unit tests to ncproxy #1143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katiewasnothere
commented
Aug 31, 2021
| if _, ok := err.(hcn.NetworkNotFoundError); ok { | ||
| return nil, status.Errorf(codes.NotFound, "no network/switch with name `%s` found", req.SwitchName) | ||
| policies := []hcn.NetworkPolicy{} | ||
| if req.SwitchName != "" { |
Author
There was a problem hiding this comment.
I added this change to allow us to make other network types than just transparent as was the previous limitation. This is also needed for the tests since we can't make transparent networks without an adapter.
Contributor
There was a problem hiding this comment.
That's fine, I didn't like how I made this required to start with.
katiewasnothere
force-pushed
the
ncproxy_tests
branch
2 times, most recently
from
199d095 to
c63024f
Compare
dcantah
reviewed
Sep 1, 2021
katiewasnothere
force-pushed
the
ncproxy_tests
branch
from
c63024f to
173bb6a
Compare
anmaxvl
reviewed
Sep 7, 2021
katiewasnothere
force-pushed
the
ncproxy_tests
branch
3 times, most recently
from
4d5976c to
8fd2e14
Compare
dcantah
reviewed
Sep 9, 2021
| V20H2 = 19042 | ||
|
|
||
| // V21H1 corresponds to Windows Server 21H1 (semi-annual channel). | ||
| V21H1 = 19043 |
Contributor
There was a problem hiding this comment.
Some of the things here, like this, feel like they'd be better off in their own commit.
Author
There was a problem hiding this comment.
I added a comment to the test to indicate why it blocks on this version
dcantah
approved these changes
Sep 9, 2021
Contributor
dcantah
left a comment
dcantah
left a comment
There was a problem hiding this comment.
Please move the osversion package change into its own commit. Testing changes lgtm
* Add mocked grpc and ttrpc services for ncproxy testing Signed-off-by: Kathryn Baldauf <[email protected]>
katiewasnothere
force-pushed
the
ncproxy_tests
branch
from
8fd2e14 to
89d75bf
Compare
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Nov 17, 2021
Related work items: microsoft#1062, microsoft#1087, microsoft#1089, microsoft#1095, microsoft#1104, microsoft#1112, microsoft#1117, microsoft#1118, microsoft#1125, microsoft#1137, microsoft#1139, microsoft#1140, microsoft#1141, microsoft#1142, microsoft#1143, microsoft#1145, microsoft#1146, microsoft#1150, microsoft#1151, microsoft#1153, microsoft#1154, microsoft#1155, microsoft#1156, microsoft#1157, microsoft#1158, microsoft#1159, microsoft#1161, microsoft#1162, microsoft#1163, microsoft#1164, microsoft#1165, microsoft#1166, microsoft#1167, microsoft#1168, microsoft#1169, microsoft#1171, microsoft#1172, microsoft#1173, microsoft#1174, microsoft#1178
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kathryn Baldauf [email protected]