Rework how working directories function for job containers #1137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmaxvl
approved these changes
Sep 8, 2021
Contributor
Author
|
Need to rebase, doing now |
Instead of taking the working directory as is, change to joining the working directory requested with where the sandbox volume is located. It's expected that the default behavior would be to treat all paths as relative to the volume as this would be equivalent to a normal Windows Server Containers behavior. For example: A working directory of C:\ would become C:\C\12345678\ A working directory of C:\work\dir would become C:\C\12345678\work\dir Signed-off-by: Daniel Canter <[email protected]>
dcantah
force-pushed
the
jobcontainer-fixworkdir
branch
from
948bd28 to
3e7e5ef
Compare
Contributor
Author
|
Actually let me add a test for this also. |
This change adds a couple tests to make sure that the working directory functions as expected. Also some very small adjustments on the dockerfiles for the other tests (which really didn't need to be changed, but makes it more explicit). Signed-off-by: Daniel Canter <[email protected]>
Contributor
Author
|
@anmaxvl Need a re-review for the tests, sorry 🥲 |
Contributor
Author
|
@katiewasnothere @ambarve If either of you have time to look at this, let me know and I can assign. Need another set of eyes. |
3 tasks
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Nov 17, 2021
Related work items: microsoft#1062, microsoft#1087, microsoft#1089, microsoft#1095, microsoft#1104, microsoft#1112, microsoft#1117, microsoft#1118, microsoft#1125, microsoft#1137, microsoft#1139, microsoft#1140, microsoft#1141, microsoft#1142, microsoft#1143, microsoft#1145, microsoft#1146, microsoft#1150, microsoft#1151, microsoft#1153, microsoft#1154, microsoft#1155, microsoft#1156, microsoft#1157, microsoft#1158, microsoft#1159, microsoft#1161, microsoft#1162, microsoft#1163, microsoft#1164, microsoft#1165, microsoft#1166, microsoft#1167, microsoft#1168, microsoft#1169, microsoft#1171, microsoft#1172, microsoft#1173, microsoft#1174, microsoft#1178
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
Rework how working directories function for job containers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of taking the working directory as is, change to joining the working directory
requested with where the sandbox volume is located. It's expected that the default behavior
would be to treat all paths as relative to the volume as this would be equivalent to a
normal Windows Server Containers behavior.
For example:
A working directory of C:\ would become C:\C\12345678
A working directory of C:\work\dir would become C:\C\12345678\work\dir
Signed-off-by: Daniel Canter [email protected]