[release/0.8] Cherry-pick PrepareLayer fixes#1131
Merged
dcantah merged 2 commits intomicrosoft:release/0.8from Aug 26, 2021
Merged
[release/0.8] Cherry-pick PrepareLayer fixes#1131dcantah merged 2 commits intomicrosoft:release/0.8from
dcantah merged 2 commits intomicrosoft:release/0.8from
Conversation
This change adds a simple retry loop to handle some behavior on RS5. Loopback VHDs used to be mounted in a different manor on RS5 (ws2019) which led to some very odd cases where things would succeed when they shouldn't have, or we'd simply timeout if an operation took too long. Many parallel invocations of this code path and stressing the machine seem to bring out the issues, but all of the possible failure paths that bring about the errors we have observed aren't known. On 19h1+ this retry loop shouldn't be needed, but the logic is to leave the loop if everything succeeded so this is harmless and shouldn't need a version check. Signed-off-by: Daniel Canter <[email protected]> (cherry picked from commit 01b9911) Signed-off-by: Daniel Canter <[email protected]>
This change adds a small sleep before a re-attempt on layer operation failures. These failures should only happen on RS5 and the probable cause is because of a different way in which container loopback vhds were mounted on this OS version. A theory of why things might go awry on RS5 is due to some events from pnp getting reported too late/early. If the prognosis is correct, a small sleep might help to try and get things back into a "good" state before a reattempt. Signed-off-by: Daniel Canter <[email protected]> (cherry picked from commit adc35b0) Signed-off-by: Daniel Canter <[email protected]>
Contributor
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks some best effort fixes for the PrepareLayer call/layer setup. The errors that these try and fix have been observed in a couple of k8s scenarios.
From: