Add ci step to validate that modules have been vendored in #1112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcantah
reviewed
Aug 13, 2021
Author
|
@SeanTAllen fyi and thoughts? |
Contributor
|
Two thoughts:
My powershell is so poor that I can't comment on anything other than the intent. |
katiewasnothere
force-pushed
the
verify_modules
branch
5 times, most recently
from
50f3aea to
5014fa4
Compare
Contributor
|
@katiewasnothere I assume you gave this a spin on your fork? |
katiewasnothere
force-pushed
the
verify_modules
branch
from
5014fa4 to
be22296
Compare
Author
|
@dcantah I updated the code again. You can see that the test vendor job fails in the checks because those modules are not up to date from previous PRs. |
Author
|
Addressed updating the modules in #1141 |
katiewasnothere
force-pushed
the
verify_modules
branch
from
be22296 to
f16cb5c
Compare
dcantah
approved these changes
Aug 31, 2021
Contributor
|
Needs a rebase because of this #1125 |
anmaxvl
approved these changes
Sep 7, 2021
katiewasnothere
force-pushed
the
verify_modules
branch
from
f16cb5c to
a2762aa
Compare
Signed-off-by: Kathryn Baldauf <[email protected]>
katiewasnothere
force-pushed
the
verify_modules
branch
from
a2762aa to
f53295d
Compare
Author
Contributor
|
Go for it |
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Nov 17, 2021
Related work items: microsoft#1062, microsoft#1087, microsoft#1089, microsoft#1095, microsoft#1104, microsoft#1112, microsoft#1117, microsoft#1118, microsoft#1125, microsoft#1137, microsoft#1139, microsoft#1140, microsoft#1141, microsoft#1142, microsoft#1143, microsoft#1145, microsoft#1146, microsoft#1150, microsoft#1151, microsoft#1153, microsoft#1154, microsoft#1155, microsoft#1156, microsoft#1157, microsoft#1158, microsoft#1159, microsoft#1161, microsoft#1162, microsoft#1163, microsoft#1164, microsoft#1165, microsoft#1166, microsoft#1167, microsoft#1168, microsoft#1169, microsoft#1171, microsoft#1172, microsoft#1173, microsoft#1174, microsoft#1178
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new script
Verify-GoModules.ps1that copies the contents of the repo into a temporary location and runsgo mod vendorandgo mod tidyin that temporary location. The file hashes of the vendor directories in the temporary location and in the repo's location are compared to determine difference.The script needs to be run as admin due to requirements of
Get-FileHash. As a result, we cannot easily get the error messages from the script.However, one benefit of using powershell for this is that we can take advantage of the
Get-FileHashcmdlet, allowing us to get a more accurate and faster result.Signed-off-by: Kathryn Baldauf [email protected]