Minor bug fixes #1093
Merged
Minor bug fixes #1093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ambarve
force-pushed
the
assigned_dev_vsmb_clone_bugfix
branch
from
d3d59dc to
d2c4d83
Compare
dcantah
approved these changes
Aug 3, 2021
Contributor
dcantah
left a comment
dcantah
left a comment
There was a problem hiding this comment.
Needs a go mod vendor+tidy judging from the CI. Changes lgtm though
ambarve
force-pushed
the
assigned_dev_vsmb_clone_bugfix
branch
2 times, most recently
from
3219f34 to
0e453ab
Compare
kevpar
reviewed
Aug 3, 2021
Contributor
|
Speaking of the device extensions stuff, it should really have a version check for it as I believe it got in fairly recently. HCS will error out with "The virtual machine or container JSON document is invalid." otherwise if a user provided an extension on a downlevel OS. I can add in a separate change or you can add here, either or. |
Contributor
Author
|
What version check should it be? And should it be only in this one location or does it have to be included at multiple locations? |
Contributor
|
@ambarve 20237 is the earliest I see it. Could just go in |
ambarve
force-pushed
the
assigned_dev_vsmb_clone_bugfix
branch
from
0e453ab to
0a9fc72
Compare
kevpar
reviewed
Aug 3, 2021
ambarve
force-pushed
the
assigned_dev_vsmb_clone_bugfix
branch
from
0a9fc72 to
46795bb
Compare
Fix container creation failure when container config has empty device extensions. Use the `getVSMBShareKey` function during vsmb share cloning. Signed-off-by: Amit Barve <[email protected]>
ambarve
force-pushed
the
assigned_dev_vsmb_clone_bugfix
branch
from
46795bb to
3d5b0eb
Compare
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Nov 17, 2021
Related work items: microsoft#930, microsoft#962, microsoft#1004, microsoft#1008, microsoft#1039, microsoft#1045, microsoft#1046, microsoft#1047, microsoft#1052, microsoft#1053, microsoft#1054, microsoft#1057, microsoft#1058, microsoft#1060, microsoft#1061, microsoft#1063, microsoft#1064, microsoft#1068, microsoft#1069, microsoft#1070, microsoft#1071, microsoft#1074, microsoft#1078, microsoft#1079, microsoft#1081, microsoft#1082, microsoft#1083, microsoft#1084, microsoft#1088, microsoft#1090, microsoft#1091, microsoft#1093, microsoft#1094, microsoft#1096, microsoft#1098, microsoft#1099, microsoft#1102, microsoft#1103, microsoft#1105, microsoft#1106, microsoft#1108, microsoft#1109, microsoft#1115, microsoft#1116, microsoft#1122, microsoft#1123, microsoft#1126
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix container creation failure when container config has empty device extensions.
Use the
getVSMBShareKeyfunction during vsmb share cloning.Signed-off-by: Amit Barve [email protected]