export annotations for use in test suite #1061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katiewasnothere
force-pushed
the
export_annotations
branch
from
0af6fbe to
901e5e1
Compare
Contributor
|
I didn't know I wanted this until now 😆 |
Contributor
|
You'll have to re-vendor hcsshim into.. hcsshim (never gets old) to get the tests passing I imagine. |
katiewasnothere
force-pushed
the
export_annotations
branch
from
901e5e1 to
33fc5a0
Compare
dcantah
reviewed
Jul 7, 2021
dcantah
reviewed
Jul 7, 2021
katiewasnothere
force-pushed
the
export_annotations
branch
from
33fc5a0 to
950c934
Compare
dcantah
reviewed
Jul 8, 2021
dcantah
reviewed
Jul 8, 2021
dcantah
reviewed
Jul 8, 2021
dcantah
reviewed
Jul 8, 2021
dcantah
approved these changes
Jul 8, 2021
Contributor
dcantah
left a comment
dcantah
left a comment
There was a problem hiding this comment.
Couple things of feedback on the comments but lgtm, thanks again 🙂
katiewasnothere
force-pushed
the
export_annotations
branch
from
950c934 to
a470afb
Compare
Signed-off-by: Kathryn Baldauf <[email protected]>
katiewasnothere
force-pushed
the
export_annotations
branch
from
a470afb to
8e69c58
Compare
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Nov 17, 2021
Related work items: microsoft#930, microsoft#962, microsoft#1004, microsoft#1008, microsoft#1039, microsoft#1045, microsoft#1046, microsoft#1047, microsoft#1052, microsoft#1053, microsoft#1054, microsoft#1057, microsoft#1058, microsoft#1060, microsoft#1061, microsoft#1063, microsoft#1064, microsoft#1068, microsoft#1069, microsoft#1070, microsoft#1071, microsoft#1074, microsoft#1078, microsoft#1079, microsoft#1081, microsoft#1082, microsoft#1083, microsoft#1084, microsoft#1088, microsoft#1090, microsoft#1091, microsoft#1093, microsoft#1094, microsoft#1096, microsoft#1098, microsoft#1099, microsoft#1102, microsoft#1103, microsoft#1105, microsoft#1106, microsoft#1108, microsoft#1109, microsoft#1115, microsoft#1116, microsoft#1122, microsoft#1123, microsoft#1126
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
…ions export annotations for use in test suite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to reduce the chances of outdated/wrong tests if an annotation is changed or removed
Signed-off-by: Kathryn Baldauf [email protected]