Support for extensible virtual disks as data disks #1039
Conversation
|
Can this PR just be generic EVD support? That should give us support for a Spaces disk for free, right? |
|
@kevpar I am not sure I understand what you mean. This PR adds the support for EVDs but also adds some verification in case that EVD is a storage space disk. So it is not limited to storage spaces. |
My thought is we can just add support for EVD and be done with it. There is no reason we need to support a special case for specific EVD providers like Storage Spaces. As long as we provide a generic EVD path, the user can use it and the lower levels of the stack should provide an error if they don't pass the right values. |
ambarve
changed the title
|
@kevpar Thanks for the explanation. I have fixed it. PTAL. |
|
Is there a corresponding cri fork change to create mounts with type |
|
@kevpar yes there is another PR is cri here: jterry75/cri#97 |
This commit adds support in hcsshim to mount an extensible virtual disk data disk into a container. In container config the host_path in the mount entry should use the format evd://<evdType>/<evdPath> to specify an extensible virtual disk. Signed-off-by: Amit Barve <[email protected]>
Related work items: microsoft#930, microsoft#962, microsoft#1004, microsoft#1008, microsoft#1039, microsoft#1045, microsoft#1046, microsoft#1047, microsoft#1052, microsoft#1053, microsoft#1054, microsoft#1057, microsoft#1058, microsoft#1060, microsoft#1061, microsoft#1063, microsoft#1064, microsoft#1068, microsoft#1069, microsoft#1070, microsoft#1071, microsoft#1074, microsoft#1078, microsoft#1079, microsoft#1081, microsoft#1082, microsoft#1083, microsoft#1084, microsoft#1088, microsoft#1090, microsoft#1091, microsoft#1093, microsoft#1094, microsoft#1096, microsoft#1098, microsoft#1099, microsoft#1102, microsoft#1103, microsoft#1105, microsoft#1106, microsoft#1108, microsoft#1109, microsoft#1115, microsoft#1116, microsoft#1122, microsoft#1123, microsoft#1126
Support for extensible virtual disks as data disks
4 participants
This commit adds support in hcsshim to mount an extensible virtual disk data disk into a
container. In container config the host_path in the mount entry should
use the format
evd://<evdType>/<evdPath>to specify an extensible virtual disk.Signed-off-by: Amit Barve [email protected]