Add option to set no direct map by default on wcow VSMB devices #1030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kathryn Baldauf <[email protected]>
katiewasnothere
force-pushed
the
vsmb_no_direct_map
branch
from
c0dbd54 to
11cd03d
Compare
anmaxvl
approved these changes
May 18, 2021
dcantah
approved these changes
May 18, 2021
Contributor
|
A bit late to the party here but, I think we should add a check similar to this one, to not allow template creation and |
dcantah
added a commit
to dcantah/hcsshim
that referenced
this pull request
May 19, 2021
In this PR (microsoft#1019) I changed how we pass annotations to the cri-containerd suite, but this PR (microsoft#1030) got in before which added a new test. This caused the CI to fail on checkin of the first PR. Always rebase kids Signed-off-by: Daniel Canter <[email protected]>
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Aug 19, 2021
Related work items: microsoft#388, microsoft#389, microsoft#393, microsoft#394, microsoft#395, microsoft#396, microsoft#397, microsoft#398, microsoft#399, microsoft#400, microsoft#401, microsoft#402, microsoft#403, microsoft#404, microsoft#405, microsoft#931, microsoft#973, microsoft#1001, microsoft#1003, microsoft#1004, microsoft#1005, microsoft#1006, microsoft#1007, microsoft#1009, microsoft#1010, microsoft#1012, microsoft#1013, microsoft#1014, microsoft#1015, microsoft#1016, microsoft#1017, microsoft#1019, microsoft#1021, microsoft#1022, microsoft#1024, microsoft#1025, microsoft#1027, microsoft#1028, microsoft#1029, microsoft#1030, microsoft#1031, microsoft#1033
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option for a user to set
NoDirectMapas a default option for VSMB mounts without needing to set the UVM to be fully physically backed.Signed-off-by: Kathryn Baldauf [email protected]