Skip to content

Request to use Debugf instead of Infof for redundant logs in isFeatureInRange #1043

Closed
#1053
Closed
Request to use Debugf instead of Infof for redundant logs in isFeatureInRange#1043
#1053
@AbelHu

Description

@AbelHu
AbelHu
opened on Jun 3, 2021

k8s version: v1.19.6
https://github.com/microsoft/hcsshim/blob/master/hcn/hcnsupport.go#L88-L106
We found that there are too many redundant logs in kubeproxy logs. It rotates kubeproxy logs too fast. We think that it should use Debugf instead of Infof for these logs in isFeatureInRange

time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 13"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 13"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 13"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 13"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 13"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 13"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 13"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 13"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 13"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 13"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 13"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 13"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 13"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 13"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 13"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 13"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 13"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 13"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 13"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 13"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 13"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 13"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 13"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 13"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 13"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 13"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 13"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 13"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 12"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 13"
time="2021-06-01T05:00:10Z" level=info msg="currentVersion.Major < versionRange.MinVersion.Major: 9, 10"

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions