-
Notifications
You must be signed in to change notification settings - Fork 285
Comparing changes
Open a pull request
base repository: microsoft/hcsshim
base: v0.9.3
head repository: microsoft/hcsshim
compare: v0.9.4
- 9 commits
- 20 files changed
- 4 contributors
Commits on Jul 21, 2022
-
Rework /internal/queue package (#1449)
* Rework /internal/queue package Given our use cases for this package, we don't need methods that don't block on reads if there's no value to be read. Due to this, I've removed the ReadOrWait function and did a small redesign of the methods to be more in line with standard queue method naming. * Change Read/Write/IsEmpty to Dequeue/Enqueue/Size and remove ReadOrWait. Now there is no version of Read/Dequeue that doesn't block if the queue is empty. * Fix up tests to be in line with this removal of the non-blocking read and simplified most of the tests. Signed-off-by: Daniel Canter <[email protected]> (cherry picked from commit 12d4cd8) Signed-off-by: Daniel Canter <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1154e47 - Browse repository at this point
Copy the full SHA 1154e47View commit details -
Add IO tracking option for job objects (#1459)
* Add IO tracking option for job objects HCS enables this to get more in depth IO stats for the silo of the container. I'd swapped hostprocess containers to querying for these stats but without the prerequisite of actually enabling them :) This change adds a new option on jobobject.Options{} to enable this functionality and adds a new test to ensure we can actually call StorageStats now. Signed-off-by: Daniel Canter <[email protected]> (cherry picked from commit 598ea47) Signed-off-by: Daniel Canter <[email protected]>Configuration menu - View commit details
-
Copy full SHA for 52a4ea9 - Browse repository at this point
Copy the full SHA 52a4ea9View commit details -
Fix unsafe uses of unsafe.Pointer (#1438)
Per rule 4 of unsafe.Pointer usage, conversion of a unsafe.Pointer to a uinptr to pass to the syscall.Syscall family should only be done in the argument list. We had a couple spots where we were passing it in as an argument to a small wrapper function until it reached the underlying syscall.Syscall*. https://pkg.go.dev/unsafe#Pointer Signed-off-by: Daniel Canter <[email protected]> (cherry picked from commit 1ec8cad) Signed-off-by: Daniel Canter <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7fbb79f - Browse repository at this point
Copy the full SHA 7fbb79fView commit details -
Remove uneccessary use of silos in jobobject tests (#1464)
Two tests added recently by yours truly don't need to be running as silos. Remove the silo field set to true. Was running into this when trying to backport a fix to a branch that doesn't have the silo work. Signed-off-by: Daniel Canter <[email protected]> (cherry picked from commit 41d8f5a) Signed-off-by: Daniel Canter <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 566e3b0 - Browse repository at this point
Copy the full SHA 566e3b0View commit details -
linter: fix linting issues (#1457)
Additionally fix the queue tests logic. Signed-off-by: Maksim An <[email protected]> (cherry picked from commit 873b8e1) Signed-off-by: Daniel Canter <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f29964f - Browse repository at this point
Copy the full SHA f29964fView commit details -
Signed-off-by: Daniel Canter <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2cc2100 - Browse repository at this point
Copy the full SHA 2cc2100View commit details
Commits on Jul 22, 2022
-
Add test case for job env expansion
Signed-off-by: James Sturtevant <[email protected]> (cherry picked from commit 9d05b5b) Signed-off-by: Daniel Canter <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ee9dc6c - Browse repository at this point
Copy the full SHA ee9dc6cView commit details -
Expand env variables to job mount path
When installing tools into container it is sometimes desirable to have those tools on the path for the current process. Since the Windows doesn't support variable expansion on the PATH variable and the job mount path as something that isn't know at runtime we need to expand it for the passer. This could go away if the mount path is no longer used in the future. Signed-off-by: James Sturtevant <[email protected]> (cherry picked from commit 014849a) Signed-off-by: Daniel Canter <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 86ef5a6 - Browse repository at this point
Copy the full SHA 86ef5a6View commit details -
Merge pull request #1465 from dcantah/hpc-storagefix
[release/0.9] Backport hostprocess fixes
Configuration menu - View commit details
-
Copy full SHA for e6107b7 - Browse repository at this point
Copy the full SHA e6107b7View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.9.3...v0.9.4