Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: microsoft/hcsshim
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.8.24
Choose a base ref
...
head repository: microsoft/hcsshim
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.8.25
Choose a head ref
  • 1 commit
  • 9 files changed
  • 2 contributors

Commits on Dec 14, 2022

  1. [release/0.8] Remove blocking wait on container exit for every exec c… 

    …reated (#1605)

* Remove blocking wait on container exit for every exec created

Commit fixes the memory leak seen in the shim.
It removes creation of channel that waits on container exit
for every new exec. Instead, the container wait channel is exposed
through WaitChannel() function which callers can use to decide
if container has exited or not.

It also fixes CI to use the same version of golang and updates golangci-lint version to v1.48

Signed-off-by: Kirtana Ashok <[email protected]>
(cherry picked from commit 5fc00c5)
Signed-off-by: Kirtana Ashok <[email protected]>

* update golangci-lint version

Signed-off-by: Kirtana Ashok <[email protected]>

Signed-off-by: Kirtana Ashok <[email protected]>
Co-authored-by: Kirtana Ashok <[email protected]>
    @kiashok
    kiashok and Kirtana Ashok authored Dec 14, 2022
    Configuration menu
    Copy the full SHA
    619117b View commit details
    Browse the repository at this point in the history
Loading