Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: microsoft/hcsshim
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.8.23
Choose a base ref
...
head repository: microsoft/hcsshim
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.8.24
Choose a head ref
  • 3 commits
  • 2 files changed
  • 2 contributors

Commits on Feb 24, 2022

  1. Bugfix for UnicodeString constructor 

    The existing UnicodeString constructor creates a unicode string object by taking the
length of a given GO string. This works fine for ASCII strings but fails when the input
string contains non ASCII characters. This change fixes it.

Signed-off-by: Amit Barve <[email protected]>
(cherry picked from commit 0afb0c9)
Signed-off-by: Daniel Canter <[email protected]>
    @ambarve @dcantah
    ambarve authored and dcantah committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    d8b34e8 View commit details
    Browse the repository at this point in the history

  2. Add test for UnicodeString Limit 

    Signed-off-by: Amit Barve <[email protected]>
(cherry picked from commit 587be85)
Signed-off-by: Daniel Canter <[email protected]>
    @ambarve @dcantah
    ambarve authored and dcantah committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    954f419 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #1306 from dcantah/cp-unicodestr-fix 

    [release/0.8] Backport 'Bugfix for UnicodeString constructor'
    @dcantah
    dcantah authored Feb 24, 2022
    Configuration menu
    Copy the full SHA
    f43a5f8 View commit details
    Browse the repository at this point in the history
Loading