Skip to content

Commit bc58c27

Browse files
helsaawykiashok
authored andcommitted
skip failing test, use gotestsum (#1820)
Signed-off-by: Hamza El-Saawy <[email protected]> (cherry picked from commit 4ede1fd) Signed-off-by: Kirtana Ashok <[email protected]>
1 parent cc35b4b commit bc58c27

1 file changed

Lines changed: 7 additions & 1 deletion

File tree

.github/workflows/ci.yml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -375,11 +375,17 @@ jobs:
375375
run: |
376376
go build -mod vendor -o "${{ github.workspace }}/src/github.com/containerd/containerd/bin/containerd-shim-runhcs-v1.exe" .\cmd\containerd-shim-runhcs-v1
377377
378+
- name: Install gotestsum
379+
run: go install gotest.tools/gotestsum@${{ env.GOTESTSUM_VERSION }}
380+
378381
- name: Run containerd integration tests
379382
shell: bash
380383
working-directory: src/github.com/containerd/containerd
381384
run: |
382-
export EXTRA_TESTFLAGS="-timeout=20m"
385+
# TODO: when https://github.com/containerd/containerd/pull/8691 makes it into the next release (container v1.6.22?), remove the skip
386+
# `-skip` is only available in go1.20
387+
export EXTRA_TESTFLAGS='-timeout=20m -run="[^(TestConvert)]"'
388+
export GOTEST='gotestsum --format=standard-verbose --debug --'
383389
make integration
384390
385391
- name: Run containerd CRI integration tests

0 commit comments

Comments
 (0)