Skip to content

Commit 1c29e9d

Browse files
authored
add longPathAware to shim manifest (#2303)
Depending on the version of Go used to build the shim binaries the process may or may not be long path aware, for example MS Go removed it microsoft/go@af3d04e. Microsoft recommends adding long path support through manifest https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation?tabs=registry#enable-long-paths-in-windows-10-version-1607-and-later Signed-off-by: Maksim An <[email protected]>
1 parent 1b09526 commit 1c29e9d

6 files changed

Lines changed: 9 additions & 3 deletions

File tree

cmd/containerd-shim-runhcs-v1/containerd-shim-runhcs-v1.exe.manifest

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,10 @@
77
<supportedOS Id="{8e0f7a12-bfb3-4fe8-b9a5-48fd50a15a9a}"/>
88
</application>
99
</compatibility>
10+
<application xmlns="urn:schemas-microsoft-com:asm.v3">
11+
<!-- Long Path Enablement -->
12+
<windowsSettings xmlns:ws2="http://schemas.microsoft.com/SMI/2016/WindowsSettings">
13+
<ws2:longPathAware>true</ws2:longPathAware>
14+
</windowsSettings>
15+
</application>
1016
</assembly>
504 Bytes
Binary file not shown.
504 Bytes
Binary file not shown.
504 Bytes
Binary file not shown.
504 Bytes
Binary file not shown.

cmd/containerd-shim-runhcs-v1/versioninfo.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,15 +20,15 @@
2020
},
2121
"StringFileInfo": {
2222
"Comments": "",
23-
"CompanyName": "",
23+
"CompanyName": "Microsoft",
2424
"FileDescription": "",
2525
"FileVersion": "",
2626
"InternalName": "",
2727
"LegalCopyright": "",
2828
"LegalTrademarks": "",
29-
"OriginalFilename": "",
29+
"OriginalFilename": "containerd-shim-runhcs-v1.exe",
3030
"PrivateBuild": "",
31-
"ProductName": "",
31+
"ProductName": "runhcs shim",
3232
"ProductVersion": "v1.0.0.0",
3333
"SpecialBuild": ""
3434
},

0 commit comments

Comments
 (0)