Skip to content

fix: do not emit "undefined" for CSS rules#297

Merged
layershifter merged 1 commit into
microsoft:mainfrom
layershifter:fix/undefined-css
Dec 20, 2022
Merged

fix: do not emit "undefined" for CSS rules#297
layershifter merged 1 commit into
microsoft:mainfrom
layershifter:fix/undefined-css

Conversation

@layershifter

Copy link
Copy Markdown
Member

Fixes #293.

@github-actions

github-actions Bot commented Dec 20, 2022

Copy link
Copy Markdown
Contributor

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
core
makeStyles + mergeClasses (runtime)
21.155 kB
7.888 kB
21.158 kB
7.89 kB
3 B
2 B
react
makeStyles + mergeClasses (runtime)
22.942 kB
8.584 kB
22.945 kB
8.586 kB
3 B
2 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
core
makeResetStyles (runtime)
17.05 kB
6.321 kB
core
makeStyles + mergeClasses (build time)
2.19 kB
1.045 kB
react
__css + mergeClasses (build time)
2.227 kB
1.046 kB
react
__styles + mergeClasses (build time)
3.946 kB
1.78 kB
react
makeResetStyles (runtime)
18.829 kB
7.053 kB
react
makeStaticStyles (runtime)
9.674 kB
4.151 kB
🤖 This report was generated against 53a659a4a00fd8e782a45af652ef8911ebf5c8d7

@layershifter layershifter marked this pull request as ready for review December 20, 2022 11:15
@layershifter layershifter requested a review from a team as a code owner December 20, 2022 11:15
@layershifter layershifter merged commit 7d2e3ba into microsoft:main Dec 20, 2022
@layershifter layershifter deleted the fix/undefined-css branch December 20, 2022 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Passing empty string to any property creates "void 0" style when build-time optimizations are enabled

2 participants