Skip to content

fix: avoid mutations in getStyleSheetForBucket#296

Merged
layershifter merged 1 commit into
microsoft:mainfrom
layershifter:fix/griffel-renderer-mut
Dec 20, 2022
Merged

fix: avoid mutations in getStyleSheetForBucket#296
layershifter merged 1 commit into
microsoft:mainfrom
layershifter:fix/griffel-renderer-mut

Conversation

@layershifter

@layershifter layershifter commented Dec 20, 2022

Copy link
Copy Markdown
Member

Fixes #295.

@ling1726

Copy link
Copy Markdown
Contributor

Please do separate PRs or name this PR a feat since we're exposing smth new in public API

@github-actions

github-actions Bot commented Dec 20, 2022

Copy link
Copy Markdown
Contributor

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react
__styles + mergeClasses (build time)
3.929 kB
1.766 kB
3.946 kB
1.78 kB
17 B
14 B
react
makeResetStyles (runtime)
18.812 kB
7.04 kB
18.829 kB
7.053 kB
17 B
13 B
react
makeStaticStyles (runtime)
9.657 kB
4.137 kB
9.674 kB
4.151 kB
17 B
14 B
react
makeStyles + mergeClasses (runtime)
22.925 kB
8.578 kB
22.942 kB
8.584 kB
17 B
6 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
core
makeResetStyles (runtime)
17.05 kB
6.321 kB
core
makeStyles + mergeClasses (build time)
2.19 kB
1.045 kB
core
makeStyles + mergeClasses (runtime)
21.155 kB
7.888 kB
react
__css + mergeClasses (build time)
2.227 kB
1.046 kB
🤖 This report was generated against 6176db7b43ca197e1136657f65003240f120f0c8

@layershifter layershifter force-pushed the fix/griffel-renderer-mut branch from 93ff1cc to b0ff22e Compare December 20, 2022 10:41
@layershifter layershifter marked this pull request as ready for review December 20, 2022 10:51
@layershifter layershifter requested a review from a team as a code owner December 20, 2022 10:51
@layershifter

Copy link
Copy Markdown
Member Author

Please do separate PRs or name this PR a feat since we're exposing smth new in public API

Done 👍

@layershifter layershifter merged commit 53a659a into microsoft:main Dec 20, 2022
@layershifter layershifter deleted the fix/griffel-renderer-mut branch December 20, 2022 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Style element attributes are shared and mutated in renderer

2 participants