Skip to content

feat: Sort media query stylesheets#141

Merged
ling1726 merged 44 commits into
mainfrom
feat/media-sorting
Jun 21, 2022
Merged

feat: Sort media query stylesheets#141
ling1726 merged 44 commits into
mainfrom
feat/media-sorting

Conversation

@ling1726

@ling1726 ling1726 commented Jun 17, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Adds compareMediaQueries option to createDOMRenderer which will be
used to sort media query stylesheets.

Updates getStyleSheetForBucket to use comparators to simplify the job
of finding the new insertion point of a stylesheet.

Fixes #129

ling1726 added 29 commits June 16, 2022 08:52
@ling1726
with isomorphic style element
5158b1d
@ling1726
feat: Create Isomorphic shim for style element
30fa145 
The isomorphic style element is intended mainly for SSR to simplify
element rendering and make future insertion more straightforward (i.e.
for media queries).
@ling1726
revert
7bf786c
@ling1726
Change files
7a2cd3a
@ling1726
add tests for createIsomorphicStyleElement
f68e196
@ling1726
remove cast
e699dc6
@ling1726
Add comments
9e03b54
@ling1726
use isomorphic stylesheet abstraction
e30b58f
@ling1726
update changefiles
a0a1f3f
@ling1726
update hydrator
f586053
@ling1726
remove outdated types
0795a63
@ling1726
add rehydration test, use style element in constructor
0e5c9ca
@ling1726
type bucketName
3a5e735
@ling1726
remove redundant style variable
048db0d
@ling1726
documentation
6b16fb8
@ling1726
fix type
e9f85cf
@ling1726
fix types
aaba06b
@ling1726
remove unnecessary import
bfc461b
@ling1726
revert getStyleSheetForBucket
1043cae
@ling1726
it kinda works
351df5d
@ling1726
merge main
dd5bb07
@ling1726
add babel preset test
7733d8e
@ling1726
Change files
af8909d
@ling1726
test normalizeCSSBucketEntry
d15dbda
@ling1726
improve types for stylesheet keys
1510cbb
@ling1726
remove outdated types
efc3e24
@ling1726
revert bad typing change
f4ada1d
@ling1726
fix type
a101393
@ling1726
feat: Sort media query stylesheets
58f0381 
Adds `compareMediaQueries` option to `createDOMRenderer` which will be
used to sort media query stylesheets.

Updates `getStyleSheetForBucket` to use comparators to simplify the job
of finding the new insertion point of a stylesheet.
@github-actions

github-actions Bot commented Jun 17, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react
makeStaticStyles (runtime)		 8.638 kB
3.771 kB		 8.982 kB
3.908 kB		 344 B
137 B
react
makeStyles + mergeClasses (runtime)		 21.816 kB
8.202 kB		 22.154 kB
8.333 kB		 338 B
131 B
react
makeStyles + mergeClasses (build time)		 3.2 kB
1.448 kB		 3.535 kB
1.595 kB		 335 B
147 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
core
makeStyles + mergeClasses (build time)		 1.8 kB
861 B
core
makeStyles + mergeClasses (runtime)		 20.394 kB
7.612 kB
🤖 This report was generated against 09a2d3b9727100a29f6e73603c154b1a7c2727b3

@ling1726 ling1726 marked this pull request as ready for review June 20, 2022 17:06
@ling1726 ling1726 requested a review from a team as a code owner June 20, 2022 17:06
ling1726
ling1726 commented Jun 20, 2022
View reviewed changes
Comment thread apps/benchmark/src/implementations/griffel/Box.tsx Outdated
ling1726
ling1726 commented Jun 20, 2022
View reviewed changes
Comment thread packages/webpack-extraction-plugin/src/webpackLoader.test.ts Outdated
layershifter
layershifter reviewed Jun 21, 2022
View reviewed changes
Comment thread packages/core/src/renderer/createDOMRenderer.ts Outdated
Comment thread packages/core/src/renderer/rehydrateRendererCache.test.ts
Comment thread packages/core/src/renderer/getStyleSheetForBucket.ts Outdated
Comment thread packages/core/src/renderer/getStyleSheetForBucket.ts Outdated
Comment thread packages/core/src/renderer/getStyleSheetForBucket.ts
Comment thread packages/core/src/renderer/getStyleSheetForBucket.test.ts
@ling1726 ling1726 requested a review from layershifter June 21, 2022 14:37
layershifter
layershifter reviewed Jun 21, 2022
View reviewed changes
Comment thread packages/core/src/renderer/createDOMRenderer.ts
@ling1726 ling1726 merged commit 5897290 into main Jun 21, 2022
@ling1726 ling1726 deleted the feat/media-sorting branch June 21, 2022 17:59
@layershifter layershifter mentioned this pull request Jun 24, 2022
Merged
@spmonahan spmonahan mentioned this pull request Jun 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@layershifter layershifter layershifter approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

makeStyles: media queries should be sorted

2 participants

@ling1726 @layershifter