Fix transform plugin so it can handle more than one matched import sources#103
Merged
Conversation
Contributor
📊 Bundle size report🤖 This report was generated against 29a69fbe8fbae8bc59c1fa1a55856427674a2b8a |
Member
|
There are CI failures on non-existing imports: You can use |
layershifter
approved these changes
Apr 25, 2022
Member
|
Was fixed in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the transform plugin only keeps tab of the last import statement where the package name (
moduleSource) is a match. For example, in:with config:
The plugin will only focus on the 3rd import line (
import { dupImport2 } from 'another-custom-package';) and then decide that there's no placement needed, thus missing the 2nd import wherecreateStylesactually exists.This PR fixes this issue by changing the
importDeclarationPathinto animportDeclarationPathsarray, so we don't miss any imports to replace.