Add Go wrappers for Get/SetVirtualDiskInformation win32 APIs.#334
Merged
Conversation
ambarve
force-pushed
the
get_set_vhd_id
branch
from
October 16, 2025 17:15
3c7179d to
acaa258
Compare
ambarve
force-pushed
the
get_set_vhd_id
branch
7 times, most recently
from
October 21, 2025 15:29
bc1a442 to
76e6a04
Compare
ambarve
force-pushed
the
get_set_vhd_id
branch
from
October 24, 2025 03:15
76e6a04 to
340edde
Compare
Some new upcoming changes require us to use Go 1.23. However, if we switch to Go 1.23 some new linter errors are showing up. This commit fixes most of the errors and adds an exclusion for integer overflow errors. Signed-off-by: Amit <[email protected]>
ambarve
force-pushed
the
get_set_vhd_id
branch
from
October 24, 2025 03:20
340edde to
c33ebee
Compare
helsaawy
approved these changes
Oct 24, 2025
helsaawy
left a comment
helsaawy
left a comment
Contributor
There was a problem hiding this comment.
VHD issue in comment, but LGTM otherwise
SetVirtualDiskInformation API is required for running confidential windows containers. The VHDs used for starting confidential pods/UVMs need to have a specific disk identifier. These newly added APIs will be used when preparing the VHDs for confidential pods. Signed-off-by: Amit <[email protected]>
ambarve
force-pushed
the
get_set_vhd_id
branch
from
October 24, 2025 17:52
c33ebee to
8f00bc7
Compare
helsaawy
approved these changes
Oct 24, 2025
anmaxvl
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SetVirtualDiskInformation API is required for running confidential windows containers. The VHDs used for starting confidential pods/UVMs need to have a specific disk identifier. These newly added APIs will be used when preparing the VHDs for confidential pods.
However, some of the standard library methods used here need Go 1.23, so the first commit updates the repo to use Go 1.23 (while fixing linter errors) and then the second commit adds the required VHD APIs.