Update dependencies to fix panic in go generate#326
Conversation
This fixes the crash when go generating Signed-off-by: Mathieu Champlon <[email protected]>
c864d0f to
60571b8
Compare
mat007
changed the title
| go 1.21 | ||
| go 1.22.0 | ||
|
|
||
| toolchain go1.22.10 |
There was a problem hiding this comment.
You can probably remove this one if it automatically added it (go modules tends to randomly add these, but adding also means that users get either down- or upgraded when running commands, so I try to avoid adding these.
| module github.com/Microsoft/go-winio | ||
|
|
||
| go 1.21 | ||
| go 1.22.0 |
There was a problem hiding this comment.
Did the updated modules enforce updating to go1.22.0, or does it accept staying on go1.21 ?
There was a problem hiding this comment.
Yes, it needs go 1.22:
$ GOTOOLCHAIN=go1.21.0 go get golang.org/x/tools/cmd/stringer
go: golang.org/x/tools/cmd/stringer: golang.org/x/[email protected] requires go >= 1.22.0 (running go 1.21.0; GOTOOLCHAIN=go1.21.0)
Signed-off-by: Mathieu Champlon <[email protected]>
2019b42 to
ebe1a7d
Compare
|
@kiashok can you trigger the CI again? |
|
All right, so this effectively fixes the «CI / Go Generate» workflow. |
@mat007 #325 might not fix all the CI issues being hit here right? The interger overflow ones especially - do you want me to look into the integer overflow lint errors? Apologies that a lot of this has fallen on you. |
Thanks @kiashok ! I can look at the lint errors in that other PR, but I need some guidance on how best to approach it, see #325 (comment) But also, do we want to merge here, or cherry-pick the commits to #325? I really don’t mind either way. 😄 |
|
@kiashok sorry for pinging you again. |
6 participants
I picked Go 1.22 because I’ve seen this in another recent PR run:
Also updating
golang.org/x/tools/cmd/stringerrequires Go 1.22:Here is what I did:
then manually edited
go.modto remove the addedtoolchain, and re-rango mod tidyto make sure it’s stable.