Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: microsoft/go-winio
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 070c828
Choose a base ref
...
head repository: microsoft/go-winio
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3c9576c
Choose a head ref
  • 16 commits
  • 55 files changed
  • 6 contributors

Commits on Apr 26, 2023

  1. [etw] Add String() functions, JSON field option (#285)

    Add `String()` functions to `etw.Level` and `etw.Opcode` types.
    
    Add `etw.JSONStringField()`, which denotes a string field containing
    JSON data.
    
    Fix doc comment casing.
    
    Signed-off-by: Hamza El-Saawy <[email protected]>
    helsaawy authored Apr 26, 2023
    Configuration menu
    Copy the full SHA
    6a0f8b6 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2023

  1. enable dependency updates (#287)

    Signed-off-by: Hamza El-Saawy <[email protected]>
    helsaawy authored May 11, 2023
    Configuration menu
    Copy the full SHA
    4f41be6 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2023

  1. Isolate tools dependencies in tools package (#293)

    Use `./tools` to prevent callers of `go-winio` from needing to add tools
    to their dependencies.
    
    Similar to microsoft/hcsshim#1840
    
    Signed-off-by: Hamza El-Saawy <[email protected]>
    helsaawy authored Jul 21, 2023
    Configuration menu
    Copy the full SHA
    10d5703 View commit details
    Browse the repository at this point in the history
  2. Update tests; run fuzzing (#294)

    Run fuzzing tests in CI.
    
    Use race detector when running tests.
    
    Add missing `t.Helper()` calls.
    
    Update test helpers in `pkg/bindfilter` to use `RtlGetNtVersionNumbers`
    instead of reading registry, and skip tests if not running as admin.
    
    Signed-off-by: Hamza El-Saawy <[email protected]>
    helsaawy authored Jul 21, 2023
    Configuration menu
    Copy the full SHA
    19a9f65 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2023

  1. Add support for flushing and disconnecting named pipes (#292)

    * Add support for disconnecting pipes
    
    Signed-off-by: David Golub <[email protected]>
    
    * Expose Flush
    
    Signed-off-by: David Golub <[email protected]>
    
    * Add test
    
    Signed-off-by: David Golub <[email protected]>
    
    * Fix lint errors
    
    Signed-off-by: David Golub <[email protected]>
    
    ---------
    
    Signed-off-by: David Golub <[email protected]>
    dgolub authored Jul 24, 2023
    Configuration menu
    Copy the full SHA
    b29bbd5 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2023

  1. Add ResolvePath tests (#276)

    Add required computestorage APIs to allow for running tests of
    `ResolvePath`.
    
    Signed-off-by: Hamza El-Saawy <[email protected]>
    helsaawy authored Aug 3, 2023
    Configuration menu
    Copy the full SHA
    704d6c6 View commit details
    Browse the repository at this point in the history
  2. [lint] Fix errors from #276 (#296)

    Signed-off-by: Hamza El-Saawy <[email protected]>
    helsaawy authored Aug 3, 2023
    Configuration menu
    Copy the full SHA
    fec52bd View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2023

  1. Switch from sycall to windows (#295)

    Where ever possible, use `golang.org/x/sys/windows` instead of `syscall`
    (which has been deprecated since go1.11).
    
    Using `windows.LocalFree` requires using `unsafe.Pointer`, which ensures
    that the Go garbage collector does not try to free memory pre-maturely
    if it was previously declared as a pointer.
    
    Since `syscall.Handle` is part of API for `vhd` package, it was left
    unchanged.
    
    For security descriptor functions, switch to using
    `windows.SECURITY_DESCRIPTOR` to avoid unnecessary byte manipulation and
    panics due to missing input validation and error checking.
    
    Signed-off-by: Hamza El-Saawy <[email protected]>
    helsaawy authored Aug 7, 2023
    Configuration menu
    Copy the full SHA
    9f0d5dc View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. [lint] Remove deprecated tar.TypeRegA (#300)

    Signed-off-by: Hamza El-Saawy <[email protected]>
    helsaawy authored Aug 9, 2023
    Configuration menu
    Copy the full SHA
    87c84cf View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. sd.go: fix calculation of security descriptor length in SddlToSecurit…

    …yDescriptor (#299)
    
    unsafe.Sizeof(windows.SECURITY_DESCRIPTOR{}) is the minimum length of the SD,
    not the actual length. Use the actual length for computing the length of the
    slice.
    
    This path also removes getSecurityDescriptorLength, which is no longer used.
    
    Fixes #298
    
    Signed-off-by: Aaron Klotz <[email protected]>
    dblohm7 authored Aug 10, 2023
    Configuration menu
    Copy the full SHA
    eb5b095 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. fix: already typo (#303)

    Signed-off-by: guoguangwu <[email protected]>
    testwill authored Aug 28, 2023
    Configuration menu
    Copy the full SHA
    e6aebd6 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. pipe.go: add DialPipeAccessImpLevel

    I would like to use impersonation on the server side of the pipe, but I
    currently cannot because all pipes are connected using the anonymous
    impersonation level.
    
    This patch adds a new function that provides the ability to explicitly
    specify the desired impersonation level.
    
    Fixes #297
    
    Signed-off-by: Aaron Klotz <[email protected]>
    dblohm7 committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    1963303 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2023

  1. Merge pull request #302 from dblohm7/implevel2

    pipe.go: add DialPipeAccessImpLevel
    msscotb authored Nov 5, 2023
    Configuration menu
    Copy the full SHA
    553a715 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2023

  1. Bug: Close hvsock handle on listen error; fix tests (#310)

    * Bug: Close hvsock handle on listen error; fix tests
    
    Close the socket created in
    `github.com/Microsoft/go-winio/pkg/ListenHvsock` if either the `Bind` or
    `Listen` calls fail.
    
    Go changed `filepath.VolumeName` code, resulting in different behavior in
    `github.com/Microsoft/go-winio/pkg/fs.GetFileSystemType`.
    Update test accordingly.
    Also add more debug logs to `pkg\fs\resolve_test.go`.
    
    Also, move add skip for fuzzing on WS2019 or older to `FuzzHvSockRxTx`
    code directly, instead of in ci.yml.
    
    See: https://go-review.googlesource.com/c/go/+/540277
    
    Signed-off-by: Hamza El-Saawy <[email protected]>
    
    * PR: unskip TestResolvePath
    
    Signed-off-by: Hamza El-Saawy <[email protected]>
    
    ---------
    
    Signed-off-by: Hamza El-Saawy <[email protected]>
    helsaawy authored Dec 18, 2023
    Configuration menu
    Copy the full SHA
    bc421d9 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2024

  1. fileinfo: internally fix FileBasicInfo memory alignment (#312)

    * fileinfo: internally fix FileBasicInfo memory alignment
    
    Signed-off-by: Davis Goodin <[email protected]>
    
    * Update test with review feedback
    
    Remove unused winName.
    
    Extract more into Windows alignment consts to repeat less.
    
    Document reason for having multiple alignment consts for the same value.
    
    Signed-off-by: Davis Goodin <[email protected]>
    
    ---------
    
    Signed-off-by: Davis Goodin <[email protected]>
    dagood authored Jan 16, 2024
    Configuration menu
    Copy the full SHA
    008bc6e View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. Update go1.21 and CI (#315)

    * Update to go 1.21
    
    Use `atomic.Bool` stdlib instead of including our own.
    
    Include `tools\mkwinsyscall` updates from go-winio/283 to switch to
    `syscallN`.
    Note: removed `// TODO` about `print`/`ln`, since the latter adds spaces
    between args when printing, which is undesired.
    
    Also update CI to run steps on windows-2022 instead of windows-2019,
    similar to our hcsshim CI.
    
    Signed-off-by: Hamza El-Saawy <[email protected]>
    
    * PR: simplify type checking
    
    Signed-off-by: Hamza El-Saawy <[email protected]>
    
    ---------
    
    Signed-off-by: Hamza El-Saawy <[email protected]>
    helsaawy authored Apr 9, 2024
    Configuration menu
    Copy the full SHA
    3c9576c View commit details
    Browse the repository at this point in the history
Loading