Skip to content

Commit cbf4dd9

Browse files
authored
pkg/etw/sample: remove dependency on github.com/sirupsen/logrus (#267)
It looks like for the purpose of the example "a" logger was needed, so not strictly logrus (probably `fmt.Println()` would've worked even). This patch removes logrus as dependency for the example. The only remaining use of logrus in this repository is now in the pkg/etc/etwlogrus package, which _does_ need logrus, but (possibly) could become its own module if we want to remove logrus as dependency of go-winio itself. Signed-off-by: Sebastiaan van Stijn <[email protected]>
1 parent 650a2e4 commit cbf4dd9

1 file changed

Lines changed: 8 additions & 13 deletions

File tree

pkg/etw/sample/main_windows.go

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,12 @@ package main
77
import (
88
"bufio"
99
"fmt"
10+
"log"
1011
"os"
1112
"runtime"
1213

1314
"github.com/Microsoft/go-winio/pkg/etw"
1415
"github.com/Microsoft/go-winio/pkg/guid"
15-
"github.com/sirupsen/logrus"
1616
)
1717

1818
func callback(sourceID guid.GUID, state etw.ProviderState, level etw.Level, matchAnyKeyword uint64, matchAllKeyword uint64, filterData uintptr) {
@@ -24,31 +24,28 @@ func main() {
2424

2525
group, err := guid.FromString("12341234-abcd-abcd-abcd-123412341234")
2626
if err != nil {
27-
logrus.Error(err)
28-
return
27+
log.Fatal(err)
2928
}
3029

3130
provider, err := etw.NewProvider("TestProvider", callback)
3231

3332
if err != nil {
34-
logrus.Error(err)
35-
return
33+
log.Fatal(err)
3634
}
3735
defer func() {
3836
if err := provider.Close(); err != nil {
39-
logrus.Error(err)
37+
log.Fatal(err)
4038
}
4139
}()
4240

4341
providerWithGroup, err := etw.NewProviderWithOptions("TestProviderWithGroup", etw.WithGroup(group), etw.WithCallback(callback))
4442

4543
if err != nil {
46-
logrus.Error(err)
47-
return
44+
log.Fatal(err)
4845
}
4946
defer func() {
5047
if err := providerWithGroup.Close(); err != nil {
51-
logrus.Error(err)
48+
log.Fatal(err)
5249
}
5350
}()
5451

@@ -80,8 +77,7 @@ func main() {
8077
"Item5",
8178
})),
8279
); err != nil {
83-
logrus.Error(err)
84-
return
80+
log.Fatal(err)
8581
}
8682

8783
if err := providerWithGroup.WriteEvent(
@@ -104,7 +100,6 @@ func main() {
104100
"Item5",
105101
})),
106102
); err != nil {
107-
logrus.Error(err)
108-
return
103+
log.Fatal(err)
109104
}
110105
}

0 commit comments

Comments
 (0)