Skip to content

Commit 650a2e4

Browse files
authored
Update version, remove deprecated linter (#265)
`structcheck` is deprecated. Update golanci-lint to 1.50. Signed-off-by: Hamza El-Saawy <[email protected]>
1 parent a059ad7 commit 650a2e4

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
- name: Run golangci-lint
1919
uses: golangci/golangci-lint-action@v3
2020
with:
21-
version: v1.48
21+
version: v1.50
2222
args: >-
2323
--verbose
2424
--timeout=5m

.golangci.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ linters:
2020
- gofmt # files are gofmt'ed
2121
- gosec # security
2222
- nilerr # returns nil even with non-nil error
23-
- structcheck # unused struct fields
2423
- unparam # unused function params
2524

2625
issues:
@@ -94,6 +93,8 @@ linters-settings:
9493
disabled: true
9594
- name: flag-parameter # excessive, and a common idiom we use
9695
disabled: true
96+
- name: unhandled-error # warns over common fmt.Print* and io.Close; rely on errcheck instead
97+
disabled: true
9798
# general config
9899
- name: line-length-limit
99100
arguments:

0 commit comments

Comments
 (0)