Remove ifdefs from ClusterStress to fix build#82
Merged
Conversation
PaulusParssinen
changed the title
vazois
reviewed
Mar 22, 2024
Sooraz2
approved these changes
Mar 22, 2024
This reverts commit ba33be6.
* Per the PR feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dotnet buildkept failing for me. Seems like either wrapping theusing System.Diagnosticsinto#ifdefor removing them from logic should fix it.Debug.Assertis still only a guard for the Debug builds unless the intent was to keep cost of theNumUtils.GetHashSlotfrom Release configuration stresstest?