Skip to content

Fix Bugs, Caused by Hello Respones Types #811#818

Merged
badrishc merged 2 commits intomicrosoft:mainfrom
yuseok-kim-edushare:Fix/hello-type
Nov 22, 2024
Merged

Fix Bugs, Caused by Hello Respones Types #811#818
badrishc merged 2 commits intomicrosoft:mainfrom
yuseok-kim-edushare:Fix/hello-type

Conversation

@yuseok-kim-edushare
Copy link
Copy Markdown
Contributor

@yuseok-kim-edushare yuseok-kim-edushare commented Nov 21, 2024

This PR will Fix Hello Responss's Type
To resolve #811

What is changed?

RESP hello command processing logic updated
to be same response as Redis's

https://github.com/redis/redis/blob/unstable/src/commands/hello.json

Thanks to @mp911de
He provide what is matter need to fix

And Also Thanks to @badrishc
He Support to me and provide tip to get trace log from garnet server

@yuseok-kim-edushare
Copy link
Copy Markdown
Contributor Author

yuseok-kim-edushare commented Nov 21, 2024

@microsoft-github-policy-service agree

@badrishc
Copy link
Copy Markdown
Collaborator

badrishc commented Nov 21, 2024

Excellent detective work! Really glad to see this get fixed :).

badrishc
badrishc reviewed Nov 21, 2024
View reviewed changes
@yuseok-kim-edushare
Copy link
Copy Markdown
Contributor Author

yuseok-kim-edushare commented Nov 22, 2024

Maybe, It's too much worrying,
but I'll try to rebase to my PR when main branch update

@badrishc badrishc merged commit 987777f into microsoft:main Nov 22, 2024
yuseok-kim-edushare added a commit to 1-Prompt-oven/auth-service that referenced this pull request Nov 25, 2024
@yuseok-kim-edushare
🔧 Update RedisConfig to following microsoft/garnet#818
9d35949
yuseok-kim-edushare added a commit to 1-Prompt-oven/gateway that referenced this pull request Nov 25, 2024
@yuseok-kim-edushare
🔧 Update RedisConfig to following microsoft/garnet#818
6c2e05a
yuseok-kim-edushare added a commit to 1-Prompt-oven/auth-service that referenced this pull request Dec 2, 2024
@yuseok-kim-edushare
🔧 Update RedisConfig to following microsoft/garnet#818
3bfcd2c
yuseok-kim-edushare added a commit to 1-Prompt-oven/auth-service that referenced this pull request Dec 2, 2024
@yuseok-kim-edushare
Squashed commit of the following:
f3f584a 
commit 1911de6
Author: yuseok-kim-edushare <[email protected]>
Date:   Fri Nov 29 14:39:52 2024 +0900

    🐛 🔊 FIx: add error message to reset PW

commit 4288b01
Author: yuseok-kim-edushare <[email protected]>
Date:   Fri Nov 29 14:35:46 2024 +0900

    🐛 🔊 로그인 실패 Error message 수정

commit f29f3d8
Author: yuseok-kim-edushare <[email protected]>
Date:   Fri Nov 29 13:38:27 2024 +0900

    🔥 remove Log of mail sender to optimize logging

commit 836cb55
Author: yuseok-kim-edushare <[email protected]>
Date:   Fri Nov 29 13:34:54 2024 +0900

    🐛 Fix: update DTO to resolve missing getter

commit 58efe5c
Author: yuseok-kim-edushare <[email protected]>
Date:   Fri Nov 29 11:39:06 2024 +0900

    :zap: add Index key to JPA -2

commit 78298cd
Author: yuseok-kim-edushare <[email protected]>
Date:   Fri Nov 29 11:35:47 2024 +0900

    :zap: add Index key to JPA

commit 29adddf
Author: yuseok-kim-edushare <[email protected]>
Date:   Thu Nov 28 21:26:11 2024 +0900

    🐛 Fix: event dto field name fix

commit 5213dd4
Author: yuseok-kim-edushare <[email protected]>
Date:   Thu Nov 28 18:52:49 2024 +0900

    🐛 Fix: API endpoint  mapping fix

commit 559cbcd
Author: 김유석(Yu Seok Kim) <[email protected]>
Date:   Wed Nov 27 11:39:33 2024 +0900

    ✨ Apply BaseResponse to RestController (#17)

    * ✨ Apply BaseResponse to RestController

    * Apply Copilot's Review

    * 🐛 Fix: File Processing Error Code가 HTTP 102로 나가면 안 됨

commit 677b8c4
Author: yuseok-kim-edushare <[email protected]>
Date:   Tue Nov 26 15:23:41 2024 +0900

    Merge branch 'main' of https://github.com/Prompt-oven/auth-service

commit 8abd021
Author: yuseok-kim-edushare <[email protected]>
Date:   Tue Nov 26 15:23:40 2024 +0900

    🐛 Fix: member Register Event field fix (email -> nickname)

commit d33fc84
Author: 김유석(Yu Seok Kim) <[email protected]>
Date:   Tue Nov 26 13:43:00 2024 +0900

    :green_heart: update CD, to ensure graceful shutdown of microservice app

commit bf30773
Author: yuseok-kim-edushare <[email protected]>
Date:   Mon Nov 25 16:40:11 2024 +0900

    🐛 Fix Kafka Producer setting (remove type header)

commit d95de01
Author: yuseok-kim-edushare <[email protected]>
Date:   Mon Nov 25 16:23:01 2024 +0900

    🐛 Fix: UpdateNickName 관련 AOP 버그 수정

commit 3fe2e59
Author: yuseok-kim-edushare <[email protected]>
Date:   Mon Nov 25 15:15:17 2024 +0900

    ✨ Feat: Member Initializer Added (root admin creation logic added)

commit 2c3a590
Author: yuseok-kim-edushare <[email protected]>
Date:   Mon Nov 25 15:04:21 2024 +0900

    ✨ Feat: Test Member initializer added

commit 393dc5e
Author: yuseok-kim-edushare <[email protected]>
Date:   Mon Nov 25 15:03:58 2024 +0900

     🐛 Fix: Member DTO-Entity Mapper missing fields update

commit 961c82e
Author: yuseok-kim-edushare <[email protected]>
Date:   Mon Nov 25 12:29:19 2024 +0900

    ♻️ Event Publish는 항상 Object(Json)으로 하기로 한 부분에 따른 Refactoring

commit 9ff582d
Author: yuseok-kim-edushare <[email protected]>
Date:   Mon Nov 25 12:03:09 2024 +0900

    ⬆ Bump: lettuce update to 6.5

commit 0deb098
Author: yuseok-kim-edushare <[email protected]>
Date:   Mon Nov 25 11:48:44 2024 +0900

    🐛 Fix: 오타 수정

commit a6216d6
Author: yuseok-kim-edushare <[email protected]>
Date:   Mon Nov 25 11:47:50 2024 +0900

    ♻️ 회원 가입 이벤트를 EventTopic Yaml에 통합

commit e029603
Author: yuseok-kim-edushare <[email protected]>
Date:   Mon Nov 25 11:47:20 2024 +0900

    🔥 불필요한 import 구문 제거

commit 3bfcd2c
Author: 김유석(Yu Seok Kim) <[email protected]>
Date:   Mon Nov 25 11:27:37 2024 +0900

    :wrench: Update RedisConfig to following microsoft/garnet#818

commit 85b5dc0
Author: 김유석(Yu Seok Kim) <[email protected]>
Date:   Sun Nov 24 22:04:48 2024 +0900

    :arrow_up: Bump: Spring Boot 3.3.5 -> 3.3.6

commit eeb3ec3
Author: yuseok-kim-edushare <[email protected]>
Date:   Fri Nov 22 10:33:58 2024 +0900

    JYXB-342 Fix: Mail body (logo svg to png)

commit f4c592a
Author: yuseok-kim-edushare <[email protected]>
Date:   Thu Nov 21 11:49:30 2024 +0900

    🚨 Hotfix: Kafka Event Consummer update

commit 1761a0b
Author: yuseok-kim-edushare <[email protected]>
Date:   Thu Nov 21 11:41:32 2024 +0900

    💚 CI/CD Docker Compose Update 구문 제거(이메일 비밀번호 환경변수 관리 위해 서버에서 작업)

commit 097da98
Author: yuseok-kim-edushare <[email protected]>
Date:   Thu Nov 21 11:25:33 2024 +0900

    🔧 메일 비밀번호 변경에 따른 수정 (환경변수화)

commit e9f2d33
Author: 김유석(Yu Seok Kim) <[email protected]>
Date:   Thu Nov 21 11:22:41 2024 +0900

    🔀Merge pull request #15 from Prompt-oven/JYXB-328-refactoring

    ♻️  Jyxb 328 refactoring

commit 68bd5b0
Author: yuseok-kim-edushare <[email protected]>
Date:   Thu Nov 21 11:22:23 2024 +0900

    ♻️ 📝 오타 최종 수정

commit 66a93bc
Author: yuseok-kim-edushare <[email protected]>
Date:   Wed Nov 20 19:49:31 2024 +0900

    ♻️ Kafka 관련 리펙토링 마저 적용(object type으로만 수신 예정)

commit 3baf450
Author: yuseok-kim-edushare <[email protected]>
Date:   Wed Nov 20 18:53:34 2024 +0900

    ♻️ Refactor: controller의 VO 에 대한 DTO-VO mapper 적용 + Oauth -> socialLogin으로 명칭 통합

commit 8603e64
Author: yuseok-kim-edushare <[email protected]>
Date:   Wed Nov 20 16:37:46 2024 +0900

    ♻️ Fix: Copilot Review 반영, Redis에서 해당 인증요청의 성공여부 불러올 때 관련 가독성 향상 등 리펙토링함

commit e444780
Author: yuseok-kim-edushare <[email protected]>
Date:   Wed Nov 20 16:33:10 2024 +0900

    ♻️ 리펙토링 마무리

commit ee9b019
Author: yuseok-kim-edushare <[email protected]>
Date:   Wed Nov 20 15:58:57 2024 +0900

    ♻️ Usecase 분류 Refactory

    - Authentication -> AccountAccess로 명칭 변경
    - 비밀번호 변경과 초기화는 맴버 스스로 자신을 관리하는 맥락의 의미로 usecase 이동
    - 닉네임, 이메일 중복검사는 검증의 의미이고, 이메일 인증 또한 검증의 의미임으로 Verification 으로 usecase 통합 및 이동

commit 594c8d6
Author: yuseok-kim-edushare <[email protected]>
Date:   Wed Nov 20 15:13:50 2024 +0900

    ♻️ social Login 관련 DTO 명칭 등 수정 및 DTO 코드 스타일 등 리펙토링

commit 89ec258
Author: yuseok-kim-edushare <[email protected]>
Date:   Wed Nov 20 11:49:20 2024 +0900

    🚨 Fix: Role 초기화 클래스 마저 수정

commit 52615b8
Author: yuseok-kim-edushare <[email protected]>
Date:   Wed Nov 20 11:46:34 2024 +0900

    ♻️ Domain Model DTO 도입해서, 도메인에 생성하는 데 필요한 데이터를 정합성 보장하며 전송하게 처리

commit 327e03f
Author: yuseok-kim-edushare <[email protected]>
Date:   Wed Nov 20 11:23:35 2024 +0900

    🚨 Fix: Signiture 안 맞춘 거 수정

commit 3cc7007
Author: yuseok-kim-edushare <[email protected]>
Date:   Wed Nov 20 11:09:06 2024 +0900

    ✨ Feat: 소셜 로그인 연동 목록 보여주는 API 추가

commit 728a5fe
Author: yuseok-kim-edushare <[email protected]>
Date:   Wed Nov 20 10:59:14 2024 +0900

    ♻️ Service의 DTO 도입 + Domain-DTO Mapper, DTO-Entity Mapper 도입

commit d63a5c5
Author: yuseok-kim-edushare <[email protected]>
Date:   Wed Nov 20 09:07:29 2024 +0900

    🔥 ♻️ 사용되지 않는 테스트 코드 삭제 (이메일 주소 검증 필요하지 않았음)

commit cda4107
Author: yuseok-kim-edushare <[email protected]>
Date:   Tue Nov 19 21:11:48 2024 +0900

    ♻️ 🚨 Fix: Refactor: 리펙토링 과정중 발생한 버그 해결 + makeMember private Method Signiture도 DTO 사용하도록 수정

commit 1445969
Author: yuseok-kim-edushare <[email protected]>
Date:   Tue Nov 19 19:44:23 2024 +0900

    ♻️ Refactor: Aspect 관련 최적화 추가(DTO에 UUID만 있으면 굳이 dto를 서비스에 끼울 필요가 없어요

commit 458614d
Author: yuseok-kim-edushare <[email protected]>
Date:   Tue Nov 19 19:35:19 2024 +0900

    ♻️ Refactor: 리펙토링

    1. VO로 받은 값을 DTO로 Wrapping 해서 사용
    2. Proxy를 DTO 사용 usecase에 맞게 업데이트

commit 445fba5
Author: 김유석(Yu Seok Kim) <[email protected]>
Date:   Tue Nov 19 10:42:06 2024 +0900

    Merge pull request #13 from Prompt-oven/JYXB-324-refactoring-events

    ♻️ 🐛  Fix & Refactor: Event related refactor (JYXB-324)

commit 7aeb308
Author: 김유석(Yu Seok Kim) <[email protected]>
Date:   Tue Nov 19 10:41:54 2024 +0900

    Merge pull request #14 from Prompt-oven/JYXB-284-fix-email-body

    Jyxb 284 fix email body

commit 8a2f144
Author: yuseok-kim-edushare <[email protected]>
Date:   Tue Nov 19 09:15:28 2024 +0900

    💄 Fix: 로고 위치 정렬 추가

commit 88d5f95
Author: yuseok-kim-edushare <[email protected]>
Date:   Mon Nov 18 23:03:03 2024 +0900

    🐛 Fix: email basemail body encoding error

    이제 한국어 지원 한다 ㅎㅎ

commit 084bb7d
Author: yuseok-kim-edushare <[email protected]>
Date:   Mon Nov 18 22:20:38 2024 +0900

    ♻️ 🐛  Fix & Refactor: Event related refactor

    1. String - Object 로 Event 형식 통일
    2. Kafka Consummer 관련 버그 수정 및 리펙토링
    - 정상적인 컨슘 동작하면서 다른 타입 컨슈머를 쉽게 추가할 수 있게 Abstract Factory의 컨셉 참고
yuseok-kim-edushare added a commit to 1-Prompt-oven/auth-service that referenced this pull request Dec 2, 2024
@yuseok-kim-edushare
🔧 Update RedisConfig to following microsoft/garnet#818
a0a6391
yuseok-kim-edushare added a commit to 1-Prompt-oven/auth-service that referenced this pull request Dec 2, 2024
@yuseok-kim-edushare
Squashed commit of the following:
6124909 
commit 74e8edd
Author: yuseok-kim-edushare <[email protected]>
Date:   Fri Nov 29 14:39:52 2024 +0900

    🐛 🔊 FIx: add error message to reset PW

commit 888cf66
Author: yuseok-kim-edushare <[email protected]>
Date:   Fri Nov 29 14:35:46 2024 +0900

    🐛 🔊 로그인 실패 Error message 수정

commit 538b78d
Author: yuseok-kim-edushare <[email protected]>
Date:   Fri Nov 29 13:38:27 2024 +0900

    🔥 remove Log of mail sender to optimize logging

commit 7f506be
Author: yuseok-kim-edushare <[email protected]>
Date:   Fri Nov 29 13:34:54 2024 +0900

    🐛 Fix: update DTO to resolve missing getter

commit e62e7f2
Author: yuseok-kim-edushare <[email protected]>
Date:   Fri Nov 29 11:39:06 2024 +0900

    :zap: add Index key to JPA -2

commit 5c06a8a
Author: yuseok-kim-edushare <[email protected]>
Date:   Fri Nov 29 11:35:47 2024 +0900

    :zap: add Index key to JPA

commit 9c0f435
Author: yuseok-kim-edushare <[email protected]>
Date:   Thu Nov 28 21:26:11 2024 +0900

    🐛 Fix: event dto field name fix

commit b90f73f
Author: yuseok-kim-edushare <[email protected]>
Date:   Thu Nov 28 18:52:49 2024 +0900

    🐛 Fix: API endpoint  mapping fix

commit f2c07d5
Author: 김유석(Yu Seok Kim) <[email protected]>
Date:   Wed Nov 27 11:39:33 2024 +0900

    ✨ Apply BaseResponse to RestController (#17)

    * ✨ Apply BaseResponse to RestController

    * Apply Copilot's Review

    * 🐛 Fix: File Processing Error Code가 HTTP 102로 나가면 안 됨

commit 99d3728
Author: yuseok-kim-edushare <[email protected]>
Date:   Tue Nov 26 15:23:41 2024 +0900

    Merge branch 'main' of https://github.com/Prompt-oven/auth-service

commit 89e2108
Author: yuseok-kim-edushare <[email protected]>
Date:   Tue Nov 26 15:23:40 2024 +0900

    🐛 Fix: member Register Event field fix (email -> nickname)

commit ee8cd1c
Author: 김유석(Yu Seok Kim) <[email protected]>
Date:   Tue Nov 26 13:43:00 2024 +0900

    :green_heart: update CD, to ensure graceful shutdown of microservice app

commit 3033a59
Author: yuseok-kim-edushare <[email protected]>
Date:   Mon Nov 25 16:40:11 2024 +0900

    🐛 Fix Kafka Producer setting (remove type header)

commit adc3892
Author: yuseok-kim-edushare <[email protected]>
Date:   Mon Nov 25 16:23:01 2024 +0900

    🐛 Fix: UpdateNickName 관련 AOP 버그 수정

commit 05ac1ba
Author: yuseok-kim-edushare <[email protected]>
Date:   Mon Nov 25 15:15:17 2024 +0900

    ✨ Feat: Member Initializer Added (root admin creation logic added)

commit c4bd07b
Author: yuseok-kim-edushare <[email protected]>
Date:   Mon Nov 25 15:04:21 2024 +0900

    ✨ Feat: Test Member initializer added

commit f1f27d1
Author: yuseok-kim-edushare <[email protected]>
Date:   Mon Nov 25 15:03:58 2024 +0900

     🐛 Fix: Member DTO-Entity Mapper missing fields update

commit d73b7ca
Author: yuseok-kim-edushare <[email protected]>
Date:   Mon Nov 25 12:29:19 2024 +0900

    ♻️ Event Publish는 항상 Object(Json)으로 하기로 한 부분에 따른 Refactoring

commit d6f5e39
Author: yuseok-kim-edushare <[email protected]>
Date:   Mon Nov 25 12:03:09 2024 +0900

    ⬆ Bump: lettuce update to 6.5

commit c940b91
Author: yuseok-kim-edushare <[email protected]>
Date:   Mon Nov 25 11:48:44 2024 +0900

    🐛 Fix: 오타 수정

commit c3184ad
Author: yuseok-kim-edushare <[email protected]>
Date:   Mon Nov 25 11:47:50 2024 +0900

    ♻️ 회원 가입 이벤트를 EventTopic Yaml에 통합

commit ad937ea
Author: yuseok-kim-edushare <[email protected]>
Date:   Mon Nov 25 11:47:20 2024 +0900

    🔥 불필요한 import 구문 제거

commit a0a6391
Author: 김유석(Yu Seok Kim) <[email protected]>
Date:   Mon Nov 25 11:27:37 2024 +0900

    :wrench: Update RedisConfig to following microsoft/garnet#818

commit 671735e
Author: 김유석(Yu Seok Kim) <[email protected]>
Date:   Sun Nov 24 22:04:48 2024 +0900

    :arrow_up: Bump: Spring Boot 3.3.5 -> 3.3.6

commit ef24217
Author: yuseok-kim-edushare <[email protected]>
Date:   Fri Nov 22 10:33:58 2024 +0900

    JYXB-342 Fix: Mail body (logo svg to png)

commit c423135
Author: yuseok-kim-edushare <[email protected]>
Date:   Thu Nov 21 11:49:30 2024 +0900

    🚨 Hotfix: Kafka Event Consummer update

commit 3cbf4fb
Author: yuseok-kim-edushare <[email protected]>
Date:   Thu Nov 21 11:41:32 2024 +0900

    💚 CI/CD Docker Compose Update 구문 제거(이메일 비밀번호 환경변수 관리 위해 서버에서 작업)

commit db125fb
Author: yuseok-kim-edushare <[email protected]>
Date:   Thu Nov 21 11:25:33 2024 +0900

    🔧 메일 비밀번호 변경에 따른 수정 (환경변수화)

commit cec9908
Author: 김유석(Yu Seok Kim) <[email protected]>
Date:   Thu Nov 21 11:22:41 2024 +0900

    🔀Merge pull request #15 from Prompt-oven/JYXB-328-refactoring

    ♻️  Jyxb 328 refactoring

commit f7cdff8
Author: yuseok-kim-edushare <[email protected]>
Date:   Thu Nov 21 11:22:23 2024 +0900

    ♻️ 📝 오타 최종 수정

commit 10039df
Author: yuseok-kim-edushare <[email protected]>
Date:   Wed Nov 20 19:49:31 2024 +0900

    ♻️ Kafka 관련 리펙토링 마저 적용(object type으로만 수신 예정)

commit 51fe3d3
Author: yuseok-kim-edushare <[email protected]>
Date:   Wed Nov 20 18:53:34 2024 +0900

    ♻️ Refactor: controller의 VO 에 대한 DTO-VO mapper 적용 + Oauth -> socialLogin으로 명칭 통합

commit e5527d7
Author: yuseok-kim-edushare <[email protected]>
Date:   Wed Nov 20 16:37:46 2024 +0900

    ♻️ Fix: Copilot Review 반영, Redis에서 해당 인증요청의 성공여부 불러올 때 관련 가독성 향상 등 리펙토링함

commit e1ff312
Author: yuseok-kim-edushare <[email protected]>
Date:   Wed Nov 20 16:33:10 2024 +0900

    ♻️ 리펙토링 마무리

commit 9b1b9cb
Author: yuseok-kim-edushare <[email protected]>
Date:   Wed Nov 20 15:58:57 2024 +0900

    ♻️ Usecase 분류 Refactory

    - Authentication -> AccountAccess로 명칭 변경
    - 비밀번호 변경과 초기화는 맴버 스스로 자신을 관리하는 맥락의 의미로 usecase 이동
    - 닉네임, 이메일 중복검사는 검증의 의미이고, 이메일 인증 또한 검증의 의미임으로 Verification 으로 usecase 통합 및 이동

commit 698ac1d
Author: yuseok-kim-edushare <[email protected]>
Date:   Wed Nov 20 15:13:50 2024 +0900

    ♻️ social Login 관련 DTO 명칭 등 수정 및 DTO 코드 스타일 등 리펙토링

commit 9b64086
Author: yuseok-kim-edushare <[email protected]>
Date:   Wed Nov 20 11:49:20 2024 +0900

    🚨 Fix: Role 초기화 클래스 마저 수정

commit 211ae6c
Author: yuseok-kim-edushare <[email protected]>
Date:   Wed Nov 20 11:46:34 2024 +0900

    ♻️ Domain Model DTO 도입해서, 도메인에 생성하는 데 필요한 데이터를 정합성 보장하며 전송하게 처리

commit 502b152
Author: yuseok-kim-edushare <[email protected]>
Date:   Wed Nov 20 11:23:35 2024 +0900

    🚨 Fix: Signiture 안 맞춘 거 수정

commit 3190c35
Author: yuseok-kim-edushare <[email protected]>
Date:   Wed Nov 20 11:09:06 2024 +0900

    ✨ Feat: 소셜 로그인 연동 목록 보여주는 API 추가

commit 07549c6
Author: yuseok-kim-edushare <[email protected]>
Date:   Wed Nov 20 10:59:14 2024 +0900

    ♻️ Service의 DTO 도입 + Domain-DTO Mapper, DTO-Entity Mapper 도입

commit 5ca483c
Author: yuseok-kim-edushare <[email protected]>
Date:   Wed Nov 20 09:07:29 2024 +0900

    🔥 ♻️ 사용되지 않는 테스트 코드 삭제 (이메일 주소 검증 필요하지 않았음)

commit 32e79fd
Author: yuseok-kim-edushare <[email protected]>
Date:   Tue Nov 19 21:11:48 2024 +0900

    ♻️ 🚨 Fix: Refactor: 리펙토링 과정중 발생한 버그 해결 + makeMember private Method Signiture도 DTO 사용하도록 수정

commit 8dfbdfa
Author: yuseok-kim-edushare <[email protected]>
Date:   Tue Nov 19 19:44:23 2024 +0900

    ♻️ Refactor: Aspect 관련 최적화 추가(DTO에 UUID만 있으면 굳이 dto를 서비스에 끼울 필요가 없어요

commit 8d1affd
Author: yuseok-kim-edushare <[email protected]>
Date:   Tue Nov 19 19:35:19 2024 +0900

    ♻️ Refactor: 리펙토링

    1. VO로 받은 값을 DTO로 Wrapping 해서 사용
    2. Proxy를 DTO 사용 usecase에 맞게 업데이트

commit ade5485
Author: 김유석(Yu Seok Kim) <[email protected]>
Date:   Tue Nov 19 10:42:06 2024 +0900

    Merge pull request #13 from Prompt-oven/JYXB-324-refactoring-events

    ♻️ 🐛  Fix & Refactor: Event related refactor (JYXB-324)

commit 7303a92
Author: 김유석(Yu Seok Kim) <[email protected]>
Date:   Tue Nov 19 10:41:54 2024 +0900

    Merge pull request #14 from Prompt-oven/JYXB-284-fix-email-body

    Jyxb 284 fix email body

commit 62dfded
Author: yuseok-kim-edushare <[email protected]>
Date:   Tue Nov 19 09:15:28 2024 +0900

    💄 Fix: 로고 위치 정렬 추가

commit 9967524
Author: yuseok-kim-edushare <[email protected]>
Date:   Mon Nov 18 23:03:03 2024 +0900

    🐛 Fix: email basemail body encoding error

    이제 한국어 지원 한다 ㅎㅎ

commit 2f3c9e9
Author: yuseok-kim-edushare <[email protected]>
Date:   Mon Nov 18 22:20:38 2024 +0900

    ♻️ 🐛  Fix & Refactor: Event related refactor

    1. String - Object 로 Event 형식 통일
    2. Kafka Consummer 관련 버그 수정 및 리펙토링
    - 정상적인 컨슘 동작하면서 다른 타입 컨슈머를 쉽게 추가할 수 있게 Abstract Factory의 컨셉 참고
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@badrishc badrishc badrishc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Conflict with Spring Data Redis with spring boot 3.3

2 participants

@yuseok-kim-edushare @badrishc