Clean TearDown failure behavior#1870
Merged
Merged
Conversation
…this makes it easier to see the real cause of a failing test
badrishc
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
TestUtils.OnTearDownwe check forLightEpochleaks, and fail if any occurred.This is a good sanity check, but can make it harder to see the cause of a real test failure.
Additionally, if
Tsavorite.core.LightEpochepochs are leaked, we will not cleanup any leakedGarnet.client.LightEpochs.PR changes
TestUtils.OnTearDownto:LightEpochif they are leakedAssert.Fail(...)on a leaked epoch if the test would pass otherwise