MurmurHash3 Bugfix#1864
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR updates MurmurHash3 tail-byte handling in HashUtils.cs, primarily by adjusting suffix length computation in the x64A variant and fixing incorrect 64-bit shifts by casting to ulong before shifting.
Changes:
- Adjusted tail length mask in
MurmurHash3x64Afromlen & 15tolen & 7. - Fixed tail-byte shifting by casting to
ulongbefore left shifts in bothMurmurHash3x64AandMurmurHash3x128.
vazois
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two existing bugs in MurmurHash3:
MurmurHash3x64AcomputessuffixLenincorrectly: it should belen & 7instead oflen & 15.ulong. Otherwise, theintdefault cannot be shifted by up to 48 bits.