charts: revert multiple timeseries per-benchmark and add AAD variants#1863
Merged
Merged
Conversation
added 2 commits
June 6, 2026 11:36
PR #1859 added Params: AAD as a 4th first-class OperationParams variant. The Featured Benchmarks view didn't surface the new AAD charts because FEATURED_BENCHMARKS only listed the (Params: None) entry for each benchmark. Add the 8 corresponding (Params: AAD) entries for the Operations.* benchmarks that gained an AAD variant. Network.* and Lua.* are unchanged since OperationsBase's useAad flag only applies to the Operations.* hierarchy.
tiagonapoli
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Revert PR #1861 (
charts: group all Params variants into one chart per benchmark) and apply the smallest possible change to surface the new AAD chart variants on the Featured Benchmarks page.