Fix VSIM COUNT when FILTER is set#1856
Merged
kevin-montrose merged 4 commits intoJun 5, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to fix VSIM response sizing when FILTER is present by ensuring the server returns at most the requested COUNT (instead of returning all post-filter matches from an over-select), and adds a regression test to cover COUNT behavior with/without FILTER and with WITHATTRIBS/WITHSCORES.
Changes:
- Add
VSIMCounttest coverage validating result cardinality withCOUNT, both with and withoutFILTER, and withWITHATTRIBS/WITHSCORES. - Update
NetworkVSIMresponse building to cap the reported/returned results toCOUNTwhen a filter bitmap is present.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
test/standalone/Garnet.test.vectorset/RespVectorSetTests.cs |
Adds VSIMCount regression test (and BinaryPrimitives usage) to validate COUNT behavior under filtering and output flags. |
libs/server/Resp/Vector/RespServerSessionVectors.cs |
Adjusts VSIM response sizing logic to cap results to COUNT when filtering is used, and changes iteration bounds accordingly. |
tiagonapoli
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
FILTERis set onVSIMwe over select to do post-filtering.We were not correctly limiting the number of result returned, instead returning whatever matched from the over select.
This fixes that.