Fixes around Vector Set migrations#1687
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens migration handling for Vector Set element reads by correctly interpreting Tsavorite read status and avoiding serialization/sending when the element read did not actually succeed.
Changes:
- Use
Status.Found(instead ofIsCompletedSuccessfully) to detect whether a Vector Set element read found a key. - Only rewrite namespaces and write/send Vector Set element records when the read result is
OK. - Simplify unified-store migration skip logic by early-returning on non-
OKread status.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
badrishc
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix some logic around Vector Set migrations - old logic incorrectly attempted to transmit missing or malformed keys.