Move EnableVectorSetPreview option over from main#1680
Merged
Conversation
vazois
approved these changes
Apr 8, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reintroduces the EnableVectorSetPreview configuration option (and related validation) into the host configuration layer, along with tests to ensure the CLI/JSON wiring and minimum page-size constraint behave as expected.
Changes:
- Add
--enable-vector-set-preview/EnableVectorSetPreviewto host options and map it intoGarnetServerOptions. - Add a new
RequiresMinimumMemoryvalidation attribute to enforce a minimumPageSizewhen the preview feature is enabled. - Add defaults.conf entry and NUnit coverage for parsing + validation scenarios.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| test/Garnet.test/GarnetServerConfigTests.cs | Adds tests for EnableVectorSetPreview parsing and minimum page size enforcement. |
| libs/host/defaults.conf | Adds default EnableVectorSetPreview: false entry. |
| libs/host/Configuration/OptionsValidators.cs | Introduces RequiresMinimumMemory validator for dependent-size constraints. |
| libs/host/Configuration/Options.cs | Adds the option definition and maps it into GarnetServerOptions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Got missed in the initial lift-and-shift of Vector Set functionality.
Pulls over --enable-vector-set-preview / EnableVectorSetPreview and tests around the same.