Issue#4832: Break BaseButton Types hard dependency from class ContextualMenu#4845
Merged
antonlabunets merged 5 commits intoMay 11, 2018
Merged
Conversation
|
|
pchandoria
changed the title
1 task
joschect
approved these changes
May 11, 2018
antonlabunets
suggested changes
May 11, 2018
antonlabunets
left a comment
antonlabunets
left a comment
Collaborator
There was a problem hiding this comment.
Let's figure out whether this really can qualify for a patch
| { | ||
| "packageName": "office-ui-fabric-react", | ||
| "comment": "Breaking BaseButton Types dependency from ContextualMenu class", | ||
| "type": "patch" |
Collaborator
Contributor
There was a problem hiding this comment.
They can still use them because it's any. This won't be breaking.
Collaborator
There was a problem hiding this comment.
On second though any covers everything and the ContextMenu was itself pointing back to IContextualMenuProps
antonlabunets
approved these changes
May 11, 2018
Markionium
added a commit
to Markionium/office-ui-fabric-react
that referenced
this pull request
May 13, 2018
…i-fabric-react into parallel-tsc * 'parallel-tsc' of https://github.com/Markionium/office-ui-fabric-react: Variants: have project use OUFR instead of just styling (microsoft#4854) Add more customization hooks to ProgressIndicator (microsoft#4566) Issue#4832: Break BaseButton Types hard dependency from class ContextualMenu (microsoft#4845) Applying package updates. Revert react portals change (microsoft#4840) Update ImageOverview.md Fixes duplicate reading of suggestions on people picker (microsoft#4765) Persona: Deprecate primaryText (microsoft#4811) Experiments: Fix Fluent theme color names (microsoft#4834) Applying package updates. Add JasonGore to command bar codeowners Fix index import (microsoft#4826) Added overflowMenuProps property to CommandBar (microsoft#4818) Fluent theme: Fix imports to use relative paths (microsoft#4831) ContextualMenuItem: adding secondaryText (microsoft#4788) ComboBox: Option Performance Optimization (microsoft#4782)
Markionium
added a commit
to Markionium/office-ui-fabric-react
that referenced
this pull request
May 13, 2018
* master: (95 commits) Variants: have project use OUFR instead of just styling (microsoft#4854) Add more customization hooks to ProgressIndicator (microsoft#4566) Issue#4832: Break BaseButton Types hard dependency from class ContextualMenu (microsoft#4845) Applying package updates. Revert react portals change (microsoft#4840) Update ImageOverview.md Fixes duplicate reading of suggestions on people picker (microsoft#4765) Persona: Deprecate primaryText (microsoft#4811) Experiments: Fix Fluent theme color names (microsoft#4834) Applying package updates. Add JasonGore to command bar codeowners Fix index import (microsoft#4826) Added overflowMenuProps property to CommandBar (microsoft#4818) Fluent theme: Fix imports to use relative paths (microsoft#4831) ContextualMenuItem: adding secondaryText (microsoft#4788) ComboBox: Option Performance Optimization (microsoft#4782) Marqueeselection style update (microsoft#4803) Applying package updates. FocusZone: Add the ability to stop focus from propagating outside the FocusZone (microsoft#4823) Unknown persona coin (microsoft#4809) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Description of changes
In an effort to reduce bundle size on critical path rendering, we are trying to defer what is not required upfront. One such control from Fabric for us is ContextualMenu, which is required for edit scenario mostly. However What we learned is we cannot chunk this from core because we need BaseButton and It has hard dependency on IContextualMenuProps. Which is fine.
Unfortunately IContextualMenuProps have hard dependency on ContextualMenu which is not fine.
export interface IContextualMenuProps extends React.Props, IWithResponsiveModeState {
Focus areas to test
This is not supposed to change any runtime behavior as change is in typing only