[MDL2]: Checkbox & ChoiceGroup #45
Conversation
atneik
commented
Aug 2, 2016
atneik
commented
- MDL2 updates for Checkbox & ChoiceGroup
- RTL
|
Hi @atneik, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
| className='ms-ChoiceField-input' | ||
| className='ms-Checkbox-input' | ||
| type='checkbox' | ||
| role='checkbox' |
There was a problem hiding this comment.
Role="checkbox" isn't needed since it's taken from the type.
| // Checkbox styles | ||
|
|
||
| $ms-checkbox-field-size: 20px; | ||
| $ms-checkbox-transition-duration: 200ms; |
There was a problem hiding this comment.
Not in the scope of this PR to change now, but boy, it would be nice if these animation values could be reconciled against what's in the animation library (or rather, have the animation library updated so we don't have one-off values like throughout the components).
| <label | ||
| htmlFor={ this._id } | ||
| className={ css('ms-Checkbox-field', isChecked && 'is-checked', !isEnabled && 'is-disabled') } | ||
|
|
|
Approved 🍷 This is awesome @atneik! Really great work. Had a few small suggestions, but otherwise this looks good! |
6 participants
