Theme generator: show in the website main nav#4251
Conversation
| <div className={ css(pageStyles.u_maxTextWidth, styles.overview) }> | ||
| <h2 id='Overview'>Overview</h2> | ||
| <p>Fabric includes 9 theme colors and 11 neutral colors. Each has helper classes for text, background, border, and hover states. When selecting colors, refer to the <a className={ styles.colorsPageLink } href={ 'https://static2.sharepointonline.com/files/fabric/fabric-website/files/coloraccessibility_29sep2016.pdf' }>color accessibility guidance (PDF)</a> to ensure that your text can be ready by everyone.</p> | ||
| <p>Fabric includes 9 theme colors and 11 neutral colors. Each has helper classes for text, background, border, and hover states. When selecting colors, refer to the <a className={ styles.colorsPageLink } href={ 'https://static2.sharepointonline.com/files/fabric/fabric-website/files/coloraccessibility_29sep2016.pdf' }>color accessibility guidance (PDF)</a> to ensure that your text can be ready by everyone. If you need to customize your theme, see the <a className={ styles.colorsPageLink } href={ '#/styles/themegenerator' }>Theme generator</a>.</p> |
There was a problem hiding this comment.
Is this true anymore? I thought we removed all the helper classes.
There was a problem hiding this comment.
Yes, this blurb refers to Fabric Core which definitely still has these classes.
|
[ssr-tests 16:59:07] Starting: webpack |
Jahnp
left a comment
Jahnp
left a comment
There was a problem hiding this comment.
Had one comment about leaving the URL for the brand-icons page for a later PR. Otherwise, everything looks great.
| { | ||
| title: 'Brand icons', | ||
| url: '#/styles/brand-icons', | ||
| url: '#/styles/brandicons', |
There was a problem hiding this comment.
Discussed in person--while it does indeed make sense for these to be consistent, doing this change will also break existing links. There may be a better way to handle a change/transition like this that won't result in a break--but we should probably look at doing that in a separate PR. That said--thanks for catching this!
4 participants
Pull request checklist
$ npm run changeDescription of changes
Focus areas to test
(optional)