Added ability for anchor menu items to have sub menus.#4198
Merged
dzearing merged 6 commits intoMar 15, 2018
Conversation
cschleiden
approved these changes
Mar 7, 2018
| */ | ||
| private _updateFocusOnMouseEvent(item: any, ev: React.MouseEvent<HTMLElement>) { | ||
| const targetElement = ev.currentTarget as HTMLElement; | ||
| const timeoutDuration = this.props.subMenuHoverDelay !== undefined ? this.props.subMenuHoverDelay : this._navigationIdleDelay; |
Contributor
There was a problem hiding this comment.
const { subMenuHoverDelay: timeoutDuration = this._navigationIdleDelay } = this.props;?
| * menu item | ||
| */ | ||
| onItemClick?: (ev?: React.MouseEvent<HTMLElement>, item?: IContextualMenuItem) => void; | ||
| onItemClick?: (ev?: React.MouseEvent<HTMLElement>, item?: IContextualMenuItem) => boolean | void; |
Contributor
There was a problem hiding this comment.
add comment explaining the return type?
Contributor
|
@dmarcey Let's move this logic into split button. Really only split buttons should have submenu and a button. |
joschect
approved these changes
Mar 13, 2018
joschect
reviewed
Mar 13, 2018
| const { contextualMenuItemAs: ChildrenRenderer = ContextualMenuItem } = this.props; | ||
|
|
||
| let { subMenuId } = this.state; | ||
| if (item.subMenuProps && item.subMenuProps.id) { |
Contributor
There was a problem hiding this comment.
Maybe put this in a method since this logic is used elsewhere.
Added prop for subMenuHoverDelay.
dmarcey
force-pushed
the
users/demarcey/anchorMenuItems
branch
from
5b1c2cb to
d0a7578
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added prop for subMenuHoverDelay.
Pull request checklist
$ npm run changeDescription of changes