CalloutContent: Remove CalloutWidth from calloutMain div#3968
Merged
montselozanod merged 2 commits intoFeb 14, 2018
Conversation
joschect
approved these changes
Feb 13, 2018
Member
|
@micahgodbolt Micah changed callout to support mergeStyles in the 6.0 branch but there are more changes @montselozanod is making here. I think we should consider just using the master version to minimize the merge conflicts in 6.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
When converting component to getStyles, calloutWidth was added by mistake to calloutmain div. It should only be part of the css of the root element.
This issue was causing the border to be hidden from the callout content main div.