Removing undocumented BaseComponent.onError handler.#3956
Merged
Conversation
lijunle
approved these changes
Feb 13, 2018
| (obj as any)[methodName] = function (): any { | ||
| let retVal; | ||
|
|
||
| try { |
Member
There was a problem hiding this comment.
I suppose this try-catch is the core meaning of this _makeSafe function. Now, after removing this try-catch logic, do we still need this _makeSafe function?
Member
Author
There was a problem hiding this comment.
Yes, though it might be more aptly named to something more clear. I was trying to minimize the change as much as possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The onError handler in BaseComponent is not needed, and is taking up extra bytes. Removing in favor of letting exceptions flow to React.
This gives the caller the opportunity to take advantage of the official error boundary support in React 16.