Datepicker: Fixing pointer on datepickers with input field#3922
Merged
lorejoh12 merged 64 commits intoFeb 13, 2018
Conversation
kellygorr
changed the title
lorejoh12
approved these changes
Feb 13, 2018
lorejoh12
left a comment
lorejoh12
left a comment
Contributor
There was a problem hiding this comment.
verified the fix in the reported case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Occurs on Datepickers with text input and no label.
When hovering mouse over the calendar icon (at the right of the datepicker), the cursor should be a pointer and not a text cursor. There was only css to do this when the datepicker had a label.
Updated icon css to have a pointer when a label is not present.
The last 3 datepicker examples were datepickers with text input. The first two datepickers had a label, so they were receiving the pointer style. The third datepicker (picture below) doesn't have a label and wasn't getting the pointer css styles.
Screenshot with fix:
