Button ex mergestyles#3863
Merged
oengusmacinog-zz merged 5 commits intoFeb 13, 2018
Merged
Conversation
gokunymbus
approved these changes
Feb 6, 2018
gokunymbus
left a comment
gokunymbus
left a comment
Contributor
There was a problem hiding this comment.
Fix the css function bits and you can complete this PR.
|
|
||
| return ( | ||
| <div className='ms-BasicButtonsExample'> | ||
| <div className={ css(classNames.example) }> |
Contributor
There was a problem hiding this comment.
We don't need the css function for one class and at all anymore because merge styles takes care of merging a bunch of class names now.
|
|
||
| return ( | ||
| <div className='ms-BasicButtonsExample'> | ||
| <div className={ css(classNames.example) }> |
Contributor
There was a problem hiding this comment.
Same thing here, we don't need the css() function.
|
|
||
| return ( | ||
| <div className='ms-BasicButtonsTwoUp'> | ||
| <div className={ css(classNames.twoup) }> |
Contributor
There was a problem hiding this comment.
Same as comment above and all other instances.
|
|
||
| return ( | ||
| <div className='ms-BasicButtonsExample'> | ||
| <div className={ css(classNames.example) }> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Converted ButtonBasicExample to use mergeStyles instead of SCSS.
Focus areas to test
Visually everything should be the same.