The size of a persona is not impacted by the presence indicator.#3845
Merged
Conversation
Member
|
@dzearing, @betrue-final-final : Seems like screener is not able to highlight the differences. Is there a known screener issue? Its very hard to see the diff at all here |
Collaborator
|
Closing and reopening retriggers the build and might get you through a clean screener check. When this PR first went in, I did see a diff that I am not seeing anymore. It could have been coming from master if it passes this time. |
lynamemi
reviewed
Feb 5, 2018
| **/ | ||
| max-width: 100%; | ||
| overflow-x: hidden; | ||
| overflow: hidden; |
Collaborator
There was a problem hiding this comment.
looks like this line is what's blocking in screener. Is there another way to accomplish what you need here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
The persona control was bigger than the personaCoin in order to include the border of the presence indicator. However the presence indicator has an absolute position so the layout should behave as if it does not exist.