ComboBox: Fix auto expand for allowFreeform#3817
Merged
jspurlin merged 2 commits intoJan 30, 2018
Merged
Conversation
…rm (but it should stay expanded if it is already open)
christiango
approved these changes
Jan 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
ComboBoxes should not auto expand on click if it allowFreeform is true
Focus areas to test
verified that the comboBox no longer autoexpands when it gets focus if allow freeform is true, but will stay expanded if it was already open (so that the IP can be placed/moved/ or a selection can be made)