Fix teaching bubble overriding all default callout props#3811
Merged
gokunymbus merged 4 commits intoJan 26, 2018
Merged
Conversation
added 2 commits
January 25, 2018 12:29
Contributor
Author
|
@battletoilet @rebeccaballantyne Here is the second PR. |
gokunymbus
approved these changes
Jan 26, 2018
| export class TeachingBubble extends BaseComponent<ITeachingBubbleProps, ITeachingBubbleState> { | ||
|
|
||
| // Specify default props values | ||
| public static defaultProps = { |
Contributor
There was a problem hiding this comment.
Unfortunately this should be deprecated and marked for removal in a future release. We want to avoid changing public contracts, even if they were added erroneously.
Contributor
There was a problem hiding this comment.
I approved but fix this first and then finish your pr 👍
Contributor
Author
There was a problem hiding this comment.
Does this new commit satisfy that req?
… then spread the default calloutProps and the _defaultCalloutProps into a new object that's passed into Callout.
gokunymbus
approved these changes
Jan 26, 2018
Collaborator
|
closing and reopening to rebuild and get a clean screener |
Contributor
Author
|
Merged master to get the screener fixes. |
jordandrako
deleted the
Fix-TeachingBubble-overridding-all-default-calloutProps
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Add private _defaultCalloutProps instead of public defaultProps to set calloutProps.
Focus areas to test
Test if adding calloutProps to TeachingBubble component doesn't override other default calloutProp properties. ie: changing the beakWidth would reset the DirectionHint direction.