Fabric icons update#3797
Conversation
|
not sure why the build isn't starting - closing and opening to prompt it |
|
Oh darn, I'm seeing a build failure for the 6pointedstar and 12pointedstar - @Jahnp how do you want to handle that enum issue? |
|
@lynamemi - can you paste here, the error you are seeing? |
|
Yeah I see those errors in the build log now. |
|
Yeah, it's weird, it looks like a build of yours did go through, but it's not updating here |
|
We may need to temporarily rename the enum values to SixPointStar and TwelvePointStar to get around the numerals issue.
Sent on the go
…________________________________
From: Peter Jahn
Sent: Wednesday, January 24, 2018 4:58:15 PM
To: OfficeDev/office-ui-fabric-react; OfficeDev/office-ui-fabric-react
Cc: Peter Jahn; Mention
Subject: Re: [OfficeDev/office-ui-fabric-react] Fabric icons update (#3797)
Ahh shoot, yes, it's tripping on the numerals. I forget how we handled this in Fabric Core, but I we had a similar problem there. @mikewheaton, do you know if we did any special work in Core to support those two values?
Sent on the go
________________________________
From: lynamemi <[email protected]>
Sent: Wednesday, January 24, 2018 4:49:20 PM
To: OfficeDev/office-ui-fabric-react
Cc: Peter Jahn; Mention
Subject: Re: [OfficeDev/office-ui-fabric-react] Fabric icons update (#3797)
Yeah, it's weird, it looks like a build of your did go through, but it's not updating here
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FOfficeDev%2Foffice-ui-fabric-react%2Fpull%2F3797%23issuecomment-360324164&data=02%7C01%7Cpejahn%40microsoft.com%7Cbd8ad68b01654a3c4f6308d5638d7905%7Cee3303d7fb734b0c8589bcd847f1c277%7C1%7C0%7C636524381626994523&sdata=j6N1iRf7mAFEG8yBmFbX5YCC0x89D6WYhQMPDNeAD54%3D&reserved=0>, or mute the thread<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAASvrl8yUaE1fX0p7OLxkAdY35rc5VEnks5tN8-QgaJpZM4RsHIn&data=02%7C01%7Cpejahn%40microsoft.com%7Cbd8ad68b01654a3c4f6308d5638d7905%7Cee3303d7fb734b0c8589bcd847f1c277%7C1%7C0%7C636524381626994523&sdata=z82yaa7iMdB3s90PEkKGYibOZ97BIv1%2FkY8OuhR48Vs%3D&reserved=0>.
|
|
We haven't done anything special in Core to handle those icon names. Can enums not start with numbers? |
|
Yep, that's the error, no enums starting with numbers. |
|
To get us unblocked for now, can @srideshpande implement what you recommended above, @Jahnp ? |
|
If I implement that, hopefully no one will break. |
|
Yeah, we would definitely need to come up with a longer term solution - same with the logos |
|
I think that's the right thing to do, yes, since we likely don't want to remove them altogether. I can start a thread with the icons team about potentially renaming those symbols since I doubt we'd be the only team affected by this. Numerals in symbol names are generally a bit sketchy. |
|
It'd be a bit painful, but we could make some changes to the icon subsetting tool to make some of these corrections at build time. It would just separate Fabric's symbol name set from the icons team's source. |
|
Icon changes are no longer breaking screener! Once we get a clean screener on master, we'll be able to get one here and close this. |
|
Good to know. Thanks! |
4 participants
Updating fabric icons in office-ui-fabric-react's
@uifabric/iconspackage