Controlled TextFields#3796
Merged
gokunymbus merged 13 commits intoJan 31, 2018
Merged
Conversation
added 6 commits
January 24, 2018 15:12
…extFields with a value prop can't be edited by users, use defaultValue instead (BREAKING CHANGE).
Contributor
|
Looks like there are some errors when building your project.
I think the Jest tests are now failing. |
added 7 commits
January 26, 2018 10:23
…ead of requiring it on the TextField component props to pass jest.
gokunymbus
approved these changes
Jan 31, 2018
gokunymbus
added a commit
that referenced
this pull request
Feb 1, 2018
This reverts commit b17a45f.
gokunymbus
added a commit
that referenced
this pull request
Feb 1, 2018
* Revert "Updating config files in @uifabric/icons package (#3851)" This reverts commit 952ad79. * Revert "Addressing Issue #3776 - Sticky component loops forever if background-color is not set for page (#3833)" This reverts commit ddc5440. * Revert "Fix issue in modal Selection handling (#3836)" This reverts commit c304b01. * Revert "Adding new WOFF files to the @uifabric/icons/fonts folder (#3848)" This reverts commit 66a91aa. * Revert "Controlled TextFields (#3796)" This reverts commit b17a45f.
Contributor
|
🎉This issue was addressed in #14836, which has now been successfully released as Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Adds the _isControlled flag to the TextField component that disabled onChange if the value prop is set, which follows developer expectations with React inputs.
Focus areas to test
This is a breaking change, developers using value instead of defaultValue will need to change to defaultValue if the field needs to be user-editable.