Fixing Picker suggestions RTL alignment#3795
Merged
kristoferbrown merged 3 commits intoJan 24, 2018
Merged
Conversation
joschect
reviewed
Jan 24, 2018
| gapSpace={ 5 } | ||
| target={ this.input.inputElement } | ||
| onDismiss={ this.dismissSuggestions } | ||
| directionalHint={ getRTL() ? DirectionalHint.bottomRightEdge : DirectionalHint.bottomLeftEdge } |
Contributor
There was a problem hiding this comment.
Remove the getRTL import.
Contributor
Author
There was a problem hiding this comment.
Great catch. It's removed now.
joschect
approved these changes
Jan 24, 2018
joschect
left a comment
joschect
left a comment
Contributor
There was a problem hiding this comment.
Approved with one request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Just setting directionalHint based on getRTL wasn't working, so this PR sets directionalHint and directionalHintForRTL to put the suggestions in the right spot.