Jolore/adding work week date range#3784
Merged
johannao76 merged 5 commits intoJan 27, 2018
Merged
Conversation
…c of work week, adding date range selection unit test for DateMath for work week
…c-react into jolore/addingWorkWeekDateRange
…that the property does nothing if not in WorkWeek view
johannao76
approved these changes
Jan 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Adding a new date range type, WorkWeek. Updating Calendar and CalendarDay components to consume a new property, SelectableDaysOfWeek, that allows consumers to specify which days of the week are in their work week. If not provided, defaults to Mon-Fri.
Updated DateMath getDateRangeArray utility method to consume new property for workWeekDays, also optional and also using the same Mon-Fri default if not provided.
Focus areas to test
Test selection logic for all date range types (day, week, work week, month), and that styling for work week is as expected (only the days in the range are highlighted, can skip days if the range is not contiguous).
for those in msft, you can test the example page running with my changes here: http://jolore/fabric/#/examples/calendar