Spin Button - Removing aria-hidden and adding aria-labels for up/down buttons#3780
Merged
Conversation
jspurlin
approved these changes
Jan 24, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
To comply with the standards set by screen readers for a spin button, an input must have 2 controls, which in the case of the spin button, is the up and down buttons. We have to remove the aria-hidden on these 2 buttons so screen readers can detect them.
Alongside of that, we should also be able to add an accessible name to the up/down buttons in the spinner.
Focus areas to test
Spin Button page in the component, specifically to see that the aria-hidden value is gone.